Skip to content

Commit f331e40

Browse files
committed
USB: serial: remove CONFIG_USB_DEBUG from sierra and option drivers
These drivers should not be relying on CONFIG_USB_DEBUG. By doing this, it prevents users of kernels that do not enable this option from enabling debugging in these drivers, unlike all other usb-serial drivers. Cc: Matthias Urlichs <smurf@smurf.noris.de> Cc: Kevin Lloyd <klloyd@sierrawireless.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 parent 6188a83 commit f331e40

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

drivers/usb/serial/option.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -383,11 +383,7 @@ static struct usb_serial_driver option_1port_device = {
383383
.read_int_callback = option_instat_callback,
384384
};
385385

386-
#ifdef CONFIG_USB_DEBUG
387386
static int debug;
388-
#else
389-
#define debug 0
390-
#endif
391387

392388
/* per port private data */
393389

@@ -991,8 +987,5 @@ MODULE_DESCRIPTION(DRIVER_DESC);
991987
MODULE_VERSION(DRIVER_VERSION);
992988
MODULE_LICENSE("GPL");
993989

994-
#ifdef CONFIG_USB_DEBUG
995990
module_param(debug, bool, S_IRUGO | S_IWUSR);
996991
MODULE_PARM_DESC(debug, "Debug messages");
997-
#endif
998-

drivers/usb/serial/sierra.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,5 @@ MODULE_LICENSE("GPL");
766766
module_param(nmea, bool, S_IRUGO | S_IWUSR);
767767
MODULE_PARM_DESC(nmea, "NMEA streaming");
768768

769-
#ifdef CONFIG_USB_DEBUG
770769
module_param(debug, bool, S_IRUGO | S_IWUSR);
771770
MODULE_PARM_DESC(debug, "Debug messages");
772-
#endif

0 commit comments

Comments
 (0)