IBM-EMAC: Delete an unnecessary check before the function call "of_dev_put"

elfring · davem330 · commit f339664c0be1 · 2015-02-04T20:29:47.000-08:00
The of_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring &lt;elfring@users.sourceforge.net&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
@@ -2367,7 +2367,7 @@ static int emac_wait_deps(struct emac_instance *dev)
 	err = emac_check_deps(dev, deps) ? 0 : -ENODEV;
 	for (i = 0; i < EMAC_DEP_COUNT; i++) {
 		of_node_put(deps[i].node);
-		if (err && deps[i].ofdev)
+		if (err)
 			of_dev_put(deps[i].ofdev);
 	}
 	if (err == 0) {

Original file line number	Diff line number	Diff line change
`@@ -2367,7 +2367,7 @@ static int emac_wait_deps(struct emac_instance *dev)`
`2367`	`2367`	`err = emac_check_deps(dev, deps) ? 0 : -ENODEV;`
`2368`	`2368`	`for (i = 0; i < EMAC_DEP_COUNT; i++) {`
`2369`	`2369`	`of_node_put(deps[i].node);`
`2370`		`- if (err && deps[i].ofdev)`
	`2370`	`+ if (err)`
`2371`	`2371`	`of_dev_put(deps[i].ofdev);`
`2372`	`2372`	`}`
`2373`	`2373`	`if (err == 0) {`