iwlwifi: pcie: fix erroneous "Read failed message"

sara-s · lucacoelho · commit f3402d6d8eb0 · 2017-11-25T17:11:20.000+02:00
Current pci dumping code code is always falling to the error
path, resulting with a constant "Read failed" message, also
for the successful reads.

Fixes: a5c932e41fdd ("iwlwifi: pcie: dump registers when HW becomes inaccessible")
Signed-off-by: Sara Sharon &lt;sara.sharon@intel.com&gt;
Signed-off-by: Luca Coelho &lt;luciano.coelho@intel.com&gt;
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c
@@ -166,6 +166,7 @@ static void iwl_trans_pcie_dump_regs(struct iwl_trans *trans)
 		print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32,
 			       4, buf, i, 0);
 	}
+	goto out;
 
 err_read:
 	print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32, 4, buf, i, 0);

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,7 @@ static void iwl_trans_pcie_dump_regs(struct iwl_trans *trans)`
`166`	`166`	`print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32,`
`167`	`167`	`4, buf, i, 0);`
`168`	`168`	`}`
	`169`	`+ goto out;`
`169`	`170`
`170`	`171`	`err_read:`
`171`	`172`	`print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32, 4, buf, i, 0);`