Skip to content

Commit f3f1769

Browse files
ChristianKoenigAMDalexdeucher
authored andcommitted
drm/amdgpu: take a BO reference for the user fence
No need for a GEM reference here. Reviewed-by: Michel Dänzer <michel.daenzer@amd.com> Signed-off-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent e9d951a commit f3f1769

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,8 @@ int amdgpu_cs_parser_init(struct amdgpu_cs_parser *p, void *data)
222222
}
223223

224224
p->uf.bo = gem_to_amdgpu_bo(gobj);
225+
amdgpu_bo_ref(p->uf.bo);
226+
drm_gem_object_unreference_unlocked(gobj);
225227
p->uf.offset = fence_data->offset;
226228
} else {
227229
ret = -EINVAL;
@@ -487,7 +489,7 @@ static void amdgpu_cs_parser_fini(struct amdgpu_cs_parser *parser, int error, bo
487489
amdgpu_ib_free(parser->adev, &parser->ibs[i]);
488490
kfree(parser->ibs);
489491
if (parser->uf.bo)
490-
drm_gem_object_unreference_unlocked(&parser->uf.bo->gem_base);
492+
amdgpu_bo_unref(&parser->uf.bo);
491493
}
492494

493495
static int amdgpu_bo_vm_update_pte(struct amdgpu_cs_parser *p,
@@ -776,7 +778,7 @@ static int amdgpu_cs_free_job(struct amdgpu_job *job)
776778
amdgpu_ib_free(job->adev, &job->ibs[i]);
777779
kfree(job->ibs);
778780
if (job->uf.bo)
779-
drm_gem_object_unreference_unlocked(&job->uf.bo->gem_base);
781+
amdgpu_bo_unref(&job->uf.bo);
780782
return 0;
781783
}
782784

0 commit comments

Comments
 (0)