Skip to content

Commit f6367b4

Browse files
Vlad Yasevichdavem330
authored andcommitted
bridge: use is_skb_forwardable in forward path
Use existing function instead of trying to use our own. Signed-off-by: Vlad Yasevich <vyasevic@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 1ee481f commit f6367b4

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

net/bridge/br_forward.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,11 @@ static inline int should_deliver(const struct net_bridge_port *p,
3535
p->state == BR_STATE_FORWARDING;
3636
}
3737

38-
static inline unsigned int packet_length(const struct sk_buff *skb)
39-
{
40-
return skb->len - (skb->protocol == htons(ETH_P_8021Q) ? VLAN_HLEN : 0);
41-
}
42-
4338
int br_dev_queue_push_xmit(struct sk_buff *skb)
4439
{
4540
/* ip_fragment doesn't copy the MAC header */
4641
if (nf_bridge_maybe_copy_header(skb) ||
47-
(packet_length(skb) > skb->dev->mtu && !skb_is_gso(skb))) {
42+
!is_skb_forwardable(skb->dev, skb)) {
4843
kfree_skb(skb);
4944
} else {
5045
skb_push(skb, ETH_HLEN);
@@ -71,7 +66,7 @@ static void __br_deliver(const struct net_bridge_port *to, struct sk_buff *skb)
7166
skb->dev = to->dev;
7267

7368
if (unlikely(netpoll_tx_running(to->br->dev))) {
74-
if (packet_length(skb) > skb->dev->mtu && !skb_is_gso(skb))
69+
if (!is_skb_forwardable(skb->dev, skb))
7570
kfree_skb(skb);
7671
else {
7772
skb_push(skb, ETH_HLEN);

0 commit comments

Comments
 (0)