Skip to content

Commit f6e109a

Browse files
andy-shevrafaeljw
authored andcommitted
device property: Advertise fwnode and device property count API calls
The documentation of fwnode and device property array API calls isn't pointing out to the shortcuts to count the number of elements of size in an array. Amend the documentation to advertise fwnode and device property count API calls. Reported-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 117ef57 commit f6e109a

File tree

1 file changed

+30
-0
lines changed

1 file changed

+30
-0
lines changed

drivers/base/property.c

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ EXPORT_SYMBOL_GPL(fwnode_property_present);
6868
* Function reads an array of u8 properties with @propname from the device
6969
* firmware description and stores them to @val if found.
7070
*
71+
* It's recommended to call device_property_count_u8() instead of calling
72+
* this function with @val equals %NULL and @nval equals 0.
73+
*
7174
* Return: number of values if @val was %NULL,
7275
* %0 if the property was found (success),
7376
* %-EINVAL if given arguments are not valid,
@@ -93,6 +96,9 @@ EXPORT_SYMBOL_GPL(device_property_read_u8_array);
9396
* Function reads an array of u16 properties with @propname from the device
9497
* firmware description and stores them to @val if found.
9598
*
99+
* It's recommended to call device_property_count_u16() instead of calling
100+
* this function with @val equals %NULL and @nval equals 0.
101+
*
96102
* Return: number of values if @val was %NULL,
97103
* %0 if the property was found (success),
98104
* %-EINVAL if given arguments are not valid,
@@ -118,6 +124,9 @@ EXPORT_SYMBOL_GPL(device_property_read_u16_array);
118124
* Function reads an array of u32 properties with @propname from the device
119125
* firmware description and stores them to @val if found.
120126
*
127+
* It's recommended to call device_property_count_u32() instead of calling
128+
* this function with @val equals %NULL and @nval equals 0.
129+
*
121130
* Return: number of values if @val was %NULL,
122131
* %0 if the property was found (success),
123132
* %-EINVAL if given arguments are not valid,
@@ -143,6 +152,9 @@ EXPORT_SYMBOL_GPL(device_property_read_u32_array);
143152
* Function reads an array of u64 properties with @propname from the device
144153
* firmware description and stores them to @val if found.
145154
*
155+
* It's recommended to call device_property_count_u64() instead of calling
156+
* this function with @val equals %NULL and @nval equals 0.
157+
*
146158
* Return: number of values if @val was %NULL,
147159
* %0 if the property was found (success),
148160
* %-EINVAL if given arguments are not valid,
@@ -168,6 +180,9 @@ EXPORT_SYMBOL_GPL(device_property_read_u64_array);
168180
* Function reads an array of string properties with @propname from the device
169181
* firmware description and stores them to @val if found.
170182
*
183+
* It's recommended to call device_property_string_array_count() instead of calling
184+
* this function with @val equals %NULL and @nval equals 0.
185+
*
171186
* Return: number of values read on success if @val is non-NULL,
172187
* number of values available on success if @val is NULL,
173188
* %-EINVAL if given arguments are not valid,
@@ -256,6 +271,9 @@ static int fwnode_property_read_int_array(const struct fwnode_handle *fwnode,
256271
* Read an array of u8 properties with @propname from @fwnode and stores them to
257272
* @val if found.
258273
*
274+
* It's recommended to call fwnode_property_count_u8() instead of calling
275+
* this function with @val equals %NULL and @nval equals 0.
276+
*
259277
* Return: number of values if @val was %NULL,
260278
* %0 if the property was found (success),
261279
* %-EINVAL if given arguments are not valid,
@@ -282,6 +300,9 @@ EXPORT_SYMBOL_GPL(fwnode_property_read_u8_array);
282300
* Read an array of u16 properties with @propname from @fwnode and store them to
283301
* @val if found.
284302
*
303+
* It's recommended to call fwnode_property_count_u16() instead of calling
304+
* this function with @val equals %NULL and @nval equals 0.
305+
*
285306
* Return: number of values if @val was %NULL,
286307
* %0 if the property was found (success),
287308
* %-EINVAL if given arguments are not valid,
@@ -308,6 +329,9 @@ EXPORT_SYMBOL_GPL(fwnode_property_read_u16_array);
308329
* Read an array of u32 properties with @propname from @fwnode store them to
309330
* @val if found.
310331
*
332+
* It's recommended to call fwnode_property_count_u32() instead of calling
333+
* this function with @val equals %NULL and @nval equals 0.
334+
*
311335
* Return: number of values if @val was %NULL,
312336
* %0 if the property was found (success),
313337
* %-EINVAL if given arguments are not valid,
@@ -334,6 +358,9 @@ EXPORT_SYMBOL_GPL(fwnode_property_read_u32_array);
334358
* Read an array of u64 properties with @propname from @fwnode and store them to
335359
* @val if found.
336360
*
361+
* It's recommended to call fwnode_property_count_u64() instead of calling
362+
* this function with @val equals %NULL and @nval equals 0.
363+
*
337364
* Return: number of values if @val was %NULL,
338365
* %0 if the property was found (success),
339366
* %-EINVAL if given arguments are not valid,
@@ -360,6 +387,9 @@ EXPORT_SYMBOL_GPL(fwnode_property_read_u64_array);
360387
* Read an string list property @propname from the given firmware node and store
361388
* them to @val if found.
362389
*
390+
* It's recommended to call fwnode_property_string_array_count() instead of calling
391+
* this function with @val equals %NULL and @nval equals 0.
392+
*
363393
* Return: number of values read on success if @val is non-NULL,
364394
* number of values available on success if @val is NULL,
365395
* %-EINVAL if given arguments are not valid,

0 commit comments

Comments
 (0)