irqchip/gic-v3: Allow LPIs to be disabled from the command line

Marc Zyngier · Marc Zyngier · commit f736d65df0ac · 2018-03-14T11:11:29.000Z
For most GICv3 implementations, enabling LPIs is a one way switch.
Once they're on, there is no turning back, which completely kills
kexec (pending tables will always be live, and we can't tell the
secondary kernel where they are).

This is really annoying if you plan to use Linux as a bootloader,
as it pretty much guarantees that the secondary kernel won't be
able to use MSIs, and may even see some memory corruption. Bad.

A workaround for this unfortunate situation is to allow the kernel
not to enable LPIs, even if the feature is present in the HW. This
would allow Linux-as-a-bootloader to leave LPIs alone, and let the
secondary kernel to do whatever it wants with them.

Let's introduce a boolean "irqchip.gicv3_nolpi" command line option
that serves that purpose.

Signed-off-by: Marc Zyngier &lt;marc.zyngier@arm.com&gt;
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
@@ -1743,6 +1743,14 @@
 			of a GICv2 controller even if the memory range
 			exposed by the device tree is too small.
 
+	irqchip.gicv3_nolpi=
+			[ARM, ARM64]
+			Force the kernel to ignore the availability of
+			LPIs (and by consequence ITSs). Intended for system
+			that use the kernel as a bootloader, and thus want
+			to let secondary kernels in charge of setting up
+			LPIs.
+
 	irqfixup	[HW]
 			When an interrupt is not handled search all handlers
 			for it. Intended to get systems with badly broken
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
@@ -613,9 +613,17 @@ static void gic_cpu_sys_reg_init(void)
 		pr_crit_once("RSS is required but GICD doesn't support it\n");
 }
 
+static bool gicv3_nolpi;
+
+static int __init gicv3_nolpi_cfg(char *buf)
+{
+	return strtobool(buf, &gicv3_nolpi);
+}
+early_param("irqchip.gicv3_nolpi", gicv3_nolpi_cfg);
+
 static int gic_dist_supports_lpis(void)
 {
-	return !!(readl_relaxed(gic_data.dist_base + GICD_TYPER) & GICD_TYPER_LPIS);
+	return !!(readl_relaxed(gic_data.dist_base + GICD_TYPER) & GICD_TYPER_LPIS) && !gicv3_nolpi;
 }
 
 static void gic_cpu_init(void)

Original file line number	Diff line number	Diff line change
`@@ -613,9 +613,17 @@ static void gic_cpu_sys_reg_init(void)`
`613`	`613`	`pr_crit_once("RSS is required but GICD doesn't support it\n");`
`614`	`614`	`}`
`615`	`615`
	`616`	`+static bool gicv3_nolpi;`
	`617`	`+`
	`618`	`+static int __init gicv3_nolpi_cfg(char *buf)`
	`619`	`+{`
	`620`	`+ return strtobool(buf, &gicv3_nolpi);`
	`621`	`+}`
	`622`	`+early_param("irqchip.gicv3_nolpi", gicv3_nolpi_cfg);`
	`623`	`+`
`616`	`624`	`static int gic_dist_supports_lpis(void)`
`617`	`625`	`{`
`618`		`- return !!(readl_relaxed(gic_data.dist_base + GICD_TYPER) & GICD_TYPER_LPIS);`
	`626`	`+ return !!(readl_relaxed(gic_data.dist_base + GICD_TYPER) & GICD_TYPER_LPIS) && !gicv3_nolpi;`
`619`	`627`	`}`
`620`	`628`
`621`	`629`	`static void gic_cpu_init(void)`