x86: Allow nesting of the debug stack IDT setting

Steven Rostedt · rostedt · commit f8988175fd70 · 2012-05-31T23:12:21.000-04:00
When the NMI handler runs, it checks if it preempted a debug handler
and if that handler is using the debug stack. If it is, it changes the
IDT table not to update the stack, otherwise it will reset the debug
stack and corrupt the debug handler it preempted.

Now that ftrace uses breakpoints to change functions from nops to
callers, many more places may hit a breakpoint. Unfortunately this
includes some of the calls that lockdep performs. Which causes issues
with the debug stack. It too needs to change the debug stack before
tracing (if called from the debug handler).

Allow the debug_stack_set_zero() and debug_stack_reset() to be nested
so that the debug handlers can take advantage of them too.

[ Used this_cpu_*() over __get_cpu_var() as suggested by H. Peter Anvin ]

Signed-off-by: Steven Rostedt &lt;rostedt@goodmis.org&gt;
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
@@ -1101,14 +1101,20 @@ int is_debug_stack(unsigned long addr)
 		 addr > (__get_cpu_var(debug_stack_addr) - DEBUG_STKSZ));
 }
 
+static DEFINE_PER_CPU(u32, debug_stack_use_ctr);
+
 void debug_stack_set_zero(void)
 {
+	this_cpu_inc(debug_stack_use_ctr);
 	load_idt((const struct desc_ptr *)&nmi_idt_descr);
 }
 
 void debug_stack_reset(void)
 {
-	load_idt((const struct desc_ptr *)&idt_descr);
+	if (WARN_ON(!this_cpu_read(debug_stack_use_ctr)))
+		return;
+	if (this_cpu_dec_return(debug_stack_use_ctr) == 0)
+		load_idt((const struct desc_ptr *)&idt_descr);
 }
 
 #else	/* CONFIG_X86_64 */

Original file line number	Diff line number	Diff line change
`@@ -1101,14 +1101,20 @@ int is_debug_stack(unsigned long addr)`
`1101`	`1101`	`addr > (__get_cpu_var(debug_stack_addr) - DEBUG_STKSZ));`
`1102`	`1102`	`}`
`1103`	`1103`
	`1104`	`+static DEFINE_PER_CPU(u32, debug_stack_use_ctr);`
	`1105`	`+`
`1104`	`1106`	`void debug_stack_set_zero(void)`
`1105`	`1107`	`{`
	`1108`	`+ this_cpu_inc(debug_stack_use_ctr);`
`1106`	`1109`	`load_idt((const struct desc_ptr *)&nmi_idt_descr);`
`1107`	`1110`	`}`
`1108`	`1111`
`1109`	`1112`	`void debug_stack_reset(void)`
`1110`	`1113`	`{`
`1111`		`- load_idt((const struct desc_ptr *)&idt_descr);`
	`1114`	`+ if (WARN_ON(!this_cpu_read(debug_stack_use_ctr)))`
	`1115`	`+ return;`
	`1116`	`+ if (this_cpu_dec_return(debug_stack_use_ctr) == 0)`
	`1117`	`+ load_idt((const struct desc_ptr *)&idt_descr);`
`1112`	`1118`	`}`
`1113`	`1119`
`1114`	`1120`	`#else /* CONFIG_X86_64 */`