Skip to content

Commit f8b7b0a

Browse files
pjvuurendavem330
authored andcommitted
nfp: add set tcp and udp header action flower offload
Previously we did not have offloading support for set TCP/UDP actions. This patch enables TC flower offload of set TCP/UDP sport and dport actions. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: Simon Horman <simon.horman@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 354b82b commit f8b7b0a

File tree

2 files changed

+51
-0
lines changed

2 files changed

+51
-0
lines changed

drivers/net/ethernet/netronome/nfp/flower/action.c

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,11 +347,40 @@ nfp_fl_set_ip6(const struct tc_action *action, int idx, u32 off,
347347
return 0;
348348
}
349349

350+
static int
351+
nfp_fl_set_tport(const struct tc_action *action, int idx, u32 off,
352+
struct nfp_fl_set_tport *set_tport, int opcode)
353+
{
354+
u32 exact, mask;
355+
u16 tmp_set_op;
356+
357+
if (off)
358+
return -EOPNOTSUPP;
359+
360+
mask = ~tcf_pedit_mask(action, idx);
361+
exact = tcf_pedit_val(action, idx);
362+
363+
if (exact & ~mask)
364+
return -EOPNOTSUPP;
365+
366+
nfp_fl_set_helper32(exact, mask, set_tport->tp_port_val,
367+
set_tport->tp_port_mask);
368+
369+
set_tport->reserved = cpu_to_be16(0);
370+
tmp_set_op = FIELD_PREP(NFP_FL_ACT_LEN_LW,
371+
sizeof(*set_tport) >> NFP_FL_LW_SIZ);
372+
tmp_set_op |= FIELD_PREP(NFP_FL_ACT_JMP_ID, opcode);
373+
set_tport->a_op = cpu_to_be16(tmp_set_op);
374+
375+
return 0;
376+
}
377+
350378
static int
351379
nfp_fl_pedit(const struct tc_action *action, char *nfp_action, int *a_len)
352380
{
353381
struct nfp_fl_set_ipv6_addr set_ip6_dst, set_ip6_src;
354382
struct nfp_fl_set_ip4_addrs set_ip_addr;
383+
struct nfp_fl_set_tport set_tport;
355384
struct nfp_fl_set_eth set_eth;
356385
enum pedit_header_type htype;
357386
int idx, nkeys, err;
@@ -361,6 +390,7 @@ nfp_fl_pedit(const struct tc_action *action, char *nfp_action, int *a_len)
361390
memset(&set_ip6_dst, 0, sizeof(set_ip6_dst));
362391
memset(&set_ip6_src, 0, sizeof(set_ip6_src));
363392
memset(&set_ip_addr, 0, sizeof(set_ip_addr));
393+
memset(&set_tport, 0, sizeof(set_tport));
364394
memset(&set_eth, 0, sizeof(set_eth));
365395
nkeys = tcf_pedit_nkeys(action);
366396

@@ -383,6 +413,14 @@ nfp_fl_pedit(const struct tc_action *action, char *nfp_action, int *a_len)
383413
err = nfp_fl_set_ip6(action, idx, offset, &set_ip6_dst,
384414
&set_ip6_src);
385415
break;
416+
case TCA_PEDIT_KEY_EX_HDR_TYPE_TCP:
417+
err = nfp_fl_set_tport(action, idx, offset, &set_tport,
418+
NFP_FL_ACTION_OPCODE_SET_TCP);
419+
break;
420+
case TCA_PEDIT_KEY_EX_HDR_TYPE_UDP:
421+
err = nfp_fl_set_tport(action, idx, offset, &set_tport,
422+
NFP_FL_ACTION_OPCODE_SET_UDP);
423+
break;
386424
default:
387425
return -EOPNOTSUPP;
388426
}
@@ -418,6 +456,10 @@ nfp_fl_pedit(const struct tc_action *action, char *nfp_action, int *a_len)
418456
act_size = sizeof(set_ip6_src);
419457
memcpy(nfp_action, &set_ip6_src, act_size);
420458
*a_len += act_size;
459+
} else if (set_tport.a_op) {
460+
act_size = sizeof(set_tport);
461+
memcpy(nfp_action, &set_tport, act_size);
462+
*a_len += act_size;
421463
}
422464

423465
return 0;

drivers/net/ethernet/netronome/nfp/flower/cmsg.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@
8181
#define NFP_FL_ACTION_OPCODE_SET_IPV4_ADDRS 9
8282
#define NFP_FL_ACTION_OPCODE_SET_IPV6_SRC 11
8383
#define NFP_FL_ACTION_OPCODE_SET_IPV6_DST 12
84+
#define NFP_FL_ACTION_OPCODE_SET_UDP 14
85+
#define NFP_FL_ACTION_OPCODE_SET_TCP 15
8486
#define NFP_FL_ACTION_OPCODE_PRE_TUNNEL 17
8587
#define NFP_FL_ACTION_OPCODE_NUM 32
8688

@@ -136,6 +138,13 @@ struct nfp_fl_set_ipv6_addr {
136138
} ipv6[4];
137139
};
138140

141+
struct nfp_fl_set_tport {
142+
__be16 a_op;
143+
__be16 reserved;
144+
u8 tp_port_mask[4];
145+
u8 tp_port_val[4];
146+
};
147+
139148
struct nfp_fl_output {
140149
__be16 a_op;
141150
__be16 flags;

0 commit comments

Comments
 (0)