Skip to content

Commit f8bab73

Browse files
mark grossLinus Torvalds
authored andcommitted
intel-iommu: PMEN support
Add support for protected memory enable bits by clearing them if they are set at startup time. Some future boot loaders or firmware could have this bit set after it loads the kernel, and it needs to be cleared if DMA's are going to happen effectively. Signed-off-by: mark gross <mgross@intel.com> Acked-by: Muli Ben-Yehuda <muli@il.ibm.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2d3a4e3 commit f8bab73

File tree

2 files changed

+24
-1
lines changed

2 files changed

+24
-1
lines changed

drivers/pci/intel-iommu.c

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,6 +692,23 @@ static int iommu_flush_iotlb_psi(struct intel_iommu *iommu, u16 did,
692692
DMA_TLB_PSI_FLUSH, non_present_entry_flush);
693693
}
694694

695+
static void iommu_disable_protect_mem_regions(struct intel_iommu *iommu)
696+
{
697+
u32 pmen;
698+
unsigned long flags;
699+
700+
spin_lock_irqsave(&iommu->register_lock, flags);
701+
pmen = readl(iommu->reg + DMAR_PMEN_REG);
702+
pmen &= ~DMA_PMEN_EPM;
703+
writel(pmen, iommu->reg + DMAR_PMEN_REG);
704+
705+
/* wait for the protected region status bit to clear */
706+
IOMMU_WAIT_OP(iommu, DMAR_PMEN_REG,
707+
readl, !(pmen & DMA_PMEN_PRS), pmen);
708+
709+
spin_unlock_irqrestore(&iommu->register_lock, flags);
710+
}
711+
695712
static int iommu_enable_translation(struct intel_iommu *iommu)
696713
{
697714
u32 sts;
@@ -745,7 +762,7 @@ static char *fault_reason_strings[] =
745762
"non-zero reserved fields in PTE",
746763
"Unknown"
747764
};
748-
#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) - 1
765+
#define MAX_FAULT_REASON_IDX (ARRAY_SIZE(fault_reason_strings) - 1)
749766

750767
char *dmar_get_fault_reason(u8 fault_reason)
751768
{
@@ -1730,6 +1747,8 @@ int __init init_dmars(void)
17301747
iommu_flush_context_global(iommu, 0);
17311748
iommu_flush_iotlb_global(iommu, 0);
17321749

1750+
iommu_disable_protect_mem_regions(iommu);
1751+
17331752
ret = iommu_enable_translation(iommu);
17341753
if (ret)
17351754
goto error;

drivers/pci/intel-iommu.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,10 @@ static inline void dmar_writeq(void __iomem *addr, u64 val)
140140
#define DMA_TLB_IH_NONLEAF (((u64)1) << 6)
141141
#define DMA_TLB_MAX_SIZE (0x3f)
142142

143+
/* PMEN_REG */
144+
#define DMA_PMEN_EPM (((u32)1)<<31)
145+
#define DMA_PMEN_PRS (((u32)1)<<0)
146+
143147
/* GCMD_REG */
144148
#define DMA_GCMD_TE (((u32)1) << 31)
145149
#define DMA_GCMD_SRTP (((u32)1) << 30)

0 commit comments

Comments
 (0)