Skip to content

Commit f8f37ca

Browse files
committed
x86/msi: Create named irq domains
Use the fwnode to create named irq domains so diagnosis works. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Jens Axboe <axboe@kernel.dk> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Keith Busch <keith.busch@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Christoph Hellwig <hch@lst.de> Link: http://lkml.kernel.org/r/20170619235444.299024560@linutronix.de
1 parent 0323b96 commit f8f37ca

File tree

1 file changed

+33
-9
lines changed
  • arch/x86/kernel/apic

1 file changed

+33
-9
lines changed

arch/x86/kernel/apic/msi.c

Lines changed: 33 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -136,13 +136,20 @@ static struct msi_domain_info pci_msi_domain_info = {
136136
.handler_name = "edge",
137137
};
138138

139-
void arch_init_msi_domain(struct irq_domain *parent)
139+
void __init arch_init_msi_domain(struct irq_domain *parent)
140140
{
141+
struct fwnode_handle *fn;
142+
141143
if (disable_apic)
142144
return;
143145

144-
msi_default_domain = pci_msi_create_irq_domain(NULL,
145-
&pci_msi_domain_info, parent);
146+
fn = irq_domain_alloc_named_fwnode("PCI-MSI");
147+
if (fn) {
148+
msi_default_domain =
149+
pci_msi_create_irq_domain(fn, &pci_msi_domain_info,
150+
parent);
151+
irq_domain_free_fwnode(fn);
152+
}
146153
if (!msi_default_domain)
147154
pr_warn("failed to initialize irqdomain for MSI/MSI-x.\n");
148155
}
@@ -230,13 +237,20 @@ static struct irq_domain *dmar_get_irq_domain(void)
230237
{
231238
static struct irq_domain *dmar_domain;
232239
static DEFINE_MUTEX(dmar_lock);
240+
struct fwnode_handle *fn;
233241

234242
mutex_lock(&dmar_lock);
235-
if (dmar_domain == NULL)
236-
dmar_domain = msi_create_irq_domain(NULL, &dmar_msi_domain_info,
243+
if (dmar_domain)
244+
goto out;
245+
246+
fn = irq_domain_alloc_named_fwnode("DMAR-MSI");
247+
if (fn) {
248+
dmar_domain = msi_create_irq_domain(fn, &dmar_msi_domain_info,
237249
x86_vector_domain);
250+
irq_domain_free_fwnode(fn);
251+
}
252+
out:
238253
mutex_unlock(&dmar_lock);
239-
240254
return dmar_domain;
241255
}
242256

@@ -326,9 +340,10 @@ static struct msi_domain_info hpet_msi_domain_info = {
326340

327341
struct irq_domain *hpet_create_irq_domain(int hpet_id)
328342
{
329-
struct irq_domain *parent;
330-
struct irq_alloc_info info;
331343
struct msi_domain_info *domain_info;
344+
struct irq_domain *parent, *d;
345+
struct irq_alloc_info info;
346+
struct fwnode_handle *fn;
332347

333348
if (x86_vector_domain == NULL)
334349
return NULL;
@@ -349,7 +364,16 @@ struct irq_domain *hpet_create_irq_domain(int hpet_id)
349364
else
350365
hpet_msi_controller.name = "IR-HPET-MSI";
351366

352-
return msi_create_irq_domain(NULL, domain_info, parent);
367+
fn = irq_domain_alloc_named_id_fwnode(hpet_msi_controller.name,
368+
hpet_id);
369+
if (!fn) {
370+
kfree(domain_info);
371+
return NULL;
372+
}
373+
374+
d = msi_create_irq_domain(fn, domain_info, parent);
375+
irq_domain_free_fwnode(fn);
376+
return d;
353377
}
354378

355379
int hpet_assign_irq(struct irq_domain *domain, struct hpet_dev *dev,

0 commit comments

Comments
 (0)