Skip to content

Commit fa4191a

Browse files
reid-pjanaszewski
reid-p
authored and
janaszewski
committed
leds: pca9532: Add device tree support
This patch adds basic device tree support for the pca9532 LEDs. Signed-off-by: Phil Reid <preid@electromag.com.au> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
1 parent 85c9036 commit fa4191a

File tree

4 files changed

+132
-9
lines changed

4 files changed

+132
-9
lines changed

‎Documentation/devicetree/bindings/leds/leds-pca9532.txt

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
*NXP - pca9532 PWM LED Driver
2+
3+
The PCA9532 family is SMBus I/O expander optimized for dimming LEDs.
4+
The PWM support 256 steps.
5+
6+
Required properties:
7+
- compatible:
8+
"nxp,pca9530"
9+
"nxp,pca9531"
10+
"nxp,pca9532"
11+
"nxp,pca9533"
12+
- reg - I2C slave address
13+
14+
Each led is represented as a sub-node of the nxp,pca9530.
15+
16+
Optional sub-node properties:
17+
- label: see Documentation/devicetree/bindings/leds/common.txt
18+
- type: Output configuration, see dt-bindings/leds/leds-pca9532.h (default NONE)
19+
- linux,default-trigger: see Documentation/devicetree/bindings/leds/common.txt
20+
21+
Example:
22+
#include <dt-bindings/leds/leds-pca9532.h>
23+
24+
leds: pca9530@60 {
25+
compatible = "nxp,pca9530";
26+
reg = <0x60>;
27+
28+
red-power {
29+
label = "pca:red:power";
30+
type = <PCA9532_TYPE_LED>;
31+
};
32+
green-power {
33+
label = "pca:green:power";
34+
type = <PCA9532_TYPE_LED>;
35+
};
36+
};
37+
38+
For more product information please see the link below:
39+
http://nxp.com/documents/data_sheet/PCA9532.pdf

‎drivers/leds/leds-pca9532.c

Lines changed: 71 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
#include <linux/workqueue.h>
2222
#include <linux/leds-pca9532.h>
2323
#include <linux/gpio.h>
24+
#include <linux/of.h>
25+
#include <linux/of_device.h>
2426

2527
/* m = num_leds*/
2628
#define PCA9532_REG_INPUT(i) ((i) >> 3)
@@ -86,9 +88,22 @@ static const struct pca9532_chip_info pca9532_chip_info_tbl[] = {
8688
},
8789
};
8890

91+
#ifdef CONFIG_OF
92+
static const struct of_device_id of_pca9532_leds_match[] = {
93+
{ .compatible = "nxp,pca9530", .data = (void *)pca9530 },
94+
{ .compatible = "nxp,pca9531", .data = (void *)pca9531 },
95+
{ .compatible = "nxp,pca9532", .data = (void *)pca9532 },
96+
{ .compatible = "nxp,pca9533", .data = (void *)pca9533 },
97+
{},
98+
};
99+
100+
MODULE_DEVICE_TABLE(of, of_pca9532_leds_match);
101+
#endif
102+
89103
static struct i2c_driver pca9532_driver = {
90104
.driver = {
91105
.name = "leds-pca953x",
106+
.of_match_table = of_match_ptr(of_pca9532_leds_match),
92107
},
93108
.probe = pca9532_probe,
94109
.remove = pca9532_remove,
@@ -354,6 +369,7 @@ static int pca9532_configure(struct i2c_client *client,
354369
led->state = pled->state;
355370
led->name = pled->name;
356371
led->ldev.name = led->name;
372+
led->ldev.default_trigger = led->default_trigger;
357373
led->ldev.brightness = LED_OFF;
358374
led->ldev.brightness_set_blocking =
359375
pca9532_set_brightness;
@@ -432,15 +448,66 @@ static int pca9532_configure(struct i2c_client *client,
432448
return err;
433449
}
434450

451+
static struct pca9532_platform_data *
452+
pca9532_of_populate_pdata(struct device *dev, struct device_node *np)
453+
{
454+
struct pca9532_platform_data *pdata;
455+
struct device_node *child;
456+
const struct of_device_id *match;
457+
int devid, maxleds;
458+
int i = 0;
459+
460+
match = of_match_device(of_pca9532_leds_match, dev);
461+
if (!match)
462+
return ERR_PTR(-ENODEV);
463+
464+
devid = (int)(uintptr_t)match->data;
465+
maxleds = pca9532_chip_info_tbl[devid].num_leds;
466+
467+
pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
468+
if (!pdata)
469+
return ERR_PTR(-ENOMEM);
470+
471+
for_each_child_of_node(np, child) {
472+
if (of_property_read_string(child, "label",
473+
&pdata->leds[i].name))
474+
pdata->leds[i].name = child->name;
475+
of_property_read_u32(child, "type", &pdata->leds[i].type);
476+
of_property_read_string(child, "linux,default-trigger",
477+
&pdata->leds[i].default_trigger);
478+
if (++i >= maxleds) {
479+
of_node_put(child);
480+
break;
481+
}
482+
}
483+
484+
return pdata;
485+
}
486+
435487
static int pca9532_probe(struct i2c_client *client,
436488
const struct i2c_device_id *id)
437489
{
490+
int devid;
438491
struct pca9532_data *data = i2c_get_clientdata(client);
439492
struct pca9532_platform_data *pca9532_pdata =
440493
dev_get_platdata(&client->dev);
441-
442-
if (!pca9532_pdata)
443-
return -EIO;
494+
struct device_node *np = client->dev.of_node;
495+
496+
if (!pca9532_pdata) {
497+
if (np) {
498+
pca9532_pdata =
499+
pca9532_of_populate_pdata(&client->dev, np);
500+
if (IS_ERR(pca9532_pdata))
501+
return PTR_ERR(pca9532_pdata);
502+
} else {
503+
dev_err(&client->dev, "no platform data\n");
504+
return -EINVAL;
505+
}
506+
devid = (int)(uintptr_t)of_match_device(
507+
of_pca9532_leds_match, &client->dev)->data;
508+
} else {
509+
devid = id->driver_data;
510+
}
444511

445512
if (!i2c_check_functionality(client->adapter,
446513
I2C_FUNC_SMBUS_BYTE_DATA))
@@ -450,7 +517,7 @@ static int pca9532_probe(struct i2c_client *client,
450517
if (!data)
451518
return -ENOMEM;
452519

453-
data->chip_info = &pca9532_chip_info_tbl[id->driver_data];
520+
data->chip_info = &pca9532_chip_info_tbl[devid];
454521

455522
dev_info(&client->dev, "setting platform data\n");
456523
i2c_set_clientdata(client, data);

‎include/dt-bindings/leds/leds-pca9532.h

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/*
2+
* This header provides constants for pca9532 LED bindings.
3+
*
4+
* This file is licensed under the terms of the GNU General Public
5+
* License version 2. This program is licensed "as is" without any
6+
* warranty of any kind, whether express or implied.
7+
*/
8+
9+
#ifndef _DT_BINDINGS_LEDS_PCA9532_H
10+
#define _DT_BINDINGS_LEDS_PCA9532_H
11+
12+
#define PCA9532_TYPE_NONE 0
13+
#define PCA9532_TYPE_LED 1
14+
#define PCA9532_TYPE_N2100_BEEP 2
15+
#define PCA9532_TYPE_GPIO 3
16+
#define PCA9532_LED_TIMER2 4
17+
18+
#endif /* _DT_BINDINGS_LEDS_PCA9532_H */

‎include/linux/leds-pca9532.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
#include <linux/leds.h>
1818
#include <linux/workqueue.h>
19+
#include <dt-bindings/leds/leds-pca9532.h>
1920

2021
enum pca9532_state {
2122
PCA9532_OFF = 0x0,
@@ -24,16 +25,14 @@ enum pca9532_state {
2425
PCA9532_PWM1 = 0x3
2526
};
2627

27-
enum pca9532_type { PCA9532_TYPE_NONE, PCA9532_TYPE_LED,
28-
PCA9532_TYPE_N2100_BEEP, PCA9532_TYPE_GPIO };
29-
3028
struct pca9532_led {
3129
u8 id;
3230
struct i2c_client *client;
33-
char *name;
31+
const char *name;
32+
const char *default_trigger;
3433
struct led_classdev ldev;
3534
struct work_struct work;
36-
enum pca9532_type type;
35+
u32 type;
3736
enum pca9532_state state;
3837
};
3938

0 commit comments

Comments
 (0)