Skip to content

Commit fb13c47

Browse files
Ming Leidavem330
authored andcommitted
usbnet: clear OPEN flag in failure path
Without clearing OPEN flag in failure path, runtime or system resume may submit interrupt/rx URB and start tx queue mistakenly on a interface in DOWN state. Signed-off-by: Ming Lei <ming.lei@canonical.com> Acked-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b9f90eb commit fb13c47

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/net/usb/usbnet.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -796,11 +796,13 @@ int usbnet_open (struct net_device *net)
796796
if (info->manage_power) {
797797
retval = info->manage_power(dev, 1);
798798
if (retval < 0)
799-
goto done;
799+
goto done_manage_power_error;
800800
usb_autopm_put_interface(dev->intf);
801801
}
802802
return retval;
803803

804+
done_manage_power_error:
805+
clear_bit(EVENT_DEV_OPEN, &dev->flags);
804806
done:
805807
usb_autopm_put_interface(dev->intf);
806808
done_nopm:

0 commit comments

Comments
 (0)