Skip to content

Commit fcf5036

Browse files
committed
powerpc/4xx/ocm: Fix fix for phys_addr_t printf warnings
My recent commit to fix the printf warnings in ocm.c got the format specifier wrong, because I copied it from the documentation without realising the square brackets are not meant as literals. This results in the address being suffixed with a literal "[p]". Actually tested this time: # cat info /sys/kernel/debug/ppc4xx_ocm PhysAddr : 0x0000000400040000 ... NC.PhysAddr : 0x0000000400040000 ... C.PhysAddr : 0x0000000000000000 Fixes: 52b88fa ("powerpc/4xx/ocm: Fix phys_addr_t printf warnings") Reported-by: Christian Lamparter <chunkeey@gmail.com> Tested-by: Christian Lamparter <chunkeey@gmail.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
1 parent 6bca515 commit fcf5036

File tree

1 file changed

+3
-3
lines changed
  • arch/powerpc/platforms/4xx

1 file changed

+3
-3
lines changed

arch/powerpc/platforms/4xx/ocm.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -237,12 +237,12 @@ static int ocm_debugfs_show(struct seq_file *m, void *v)
237237
continue;
238238

239239
seq_printf(m, "PPC4XX OCM : %d\n", ocm->index);
240-
seq_printf(m, "PhysAddr : %pa[p]\n", &(ocm->phys));
240+
seq_printf(m, "PhysAddr : %pa\n", &(ocm->phys));
241241
seq_printf(m, "MemTotal : %d Bytes\n", ocm->memtotal);
242242
seq_printf(m, "MemTotal(NC) : %d Bytes\n", ocm->nc.memtotal);
243243
seq_printf(m, "MemTotal(C) : %d Bytes\n\n", ocm->c.memtotal);
244244

245-
seq_printf(m, "NC.PhysAddr : %pa[p]\n", &(ocm->nc.phys));
245+
seq_printf(m, "NC.PhysAddr : %pa\n", &(ocm->nc.phys));
246246
seq_printf(m, "NC.VirtAddr : 0x%p\n", ocm->nc.virt);
247247
seq_printf(m, "NC.MemTotal : %d Bytes\n", ocm->nc.memtotal);
248248
seq_printf(m, "NC.MemFree : %d Bytes\n", ocm->nc.memfree);
@@ -252,7 +252,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v)
252252
blk->size, blk->owner);
253253
}
254254

255-
seq_printf(m, "\nC.PhysAddr : %pa[p]\n", &(ocm->c.phys));
255+
seq_printf(m, "\nC.PhysAddr : %pa\n", &(ocm->c.phys));
256256
seq_printf(m, "C.VirtAddr : 0x%p\n", ocm->c.virt);
257257
seq_printf(m, "C.MemTotal : %d Bytes\n", ocm->c.memtotal);
258258
seq_printf(m, "C.MemFree : %d Bytes\n", ocm->c.memfree);

0 commit comments

Comments
 (0)