scsi: mvumi: use __maybe_unused to hide pm functions

arndb · martinkpetersen · commit fddbeb80a904 · 2016-03-05T17:07:46.000-05:00
The mvumi scsi hides the references to its suspend/resume functions in
an #ifdef but does not hide the implementation the same way:

drivers/scsi/mvumi.c:2632:12: error: 'mvumi_suspend' defined but not used [-Werror=unused-function]
drivers/scsi/mvumi.c:2651:12: error: 'mvumi_resume' defined but not used [-Werror=unused-function]

This adds __maybe_unused annotations so the compiler knows it can
silently drop them instead of warning, while avoiding the addition of
another #ifdef.

Signed-off-by: Arnd Bergmann &lt;arnd@arndb.de&gt;
Reviewed-by: Johannes Thumshirn &lt;jthumshirn@suse.de&gt;
Signed-off-by: Martin K. Petersen &lt;martin.petersen@oracle.com&gt;
diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
@@ -2629,7 +2629,7 @@ static void mvumi_shutdown(struct pci_dev *pdev)
 	mvumi_flush_cache(mhba);
 }
 
-static int mvumi_suspend(struct pci_dev *pdev, pm_message_t state)
+static int __maybe_unused mvumi_suspend(struct pci_dev *pdev, pm_message_t state)
 {
 	struct mvumi_hba *mhba = NULL;
 
@@ -2648,7 +2648,7 @@ static int mvumi_suspend(struct pci_dev *pdev, pm_message_t state)
 	return 0;
 }
 
-static int mvumi_resume(struct pci_dev *pdev)
+static int __maybe_unused mvumi_resume(struct pci_dev *pdev)
 {
 	int ret;
 	struct mvumi_hba *mhba = NULL;

Original file line number	Diff line number	Diff line change
`@@ -2629,7 +2629,7 @@ static void mvumi_shutdown(struct pci_dev *pdev)`
`2629`	`2629`	`mvumi_flush_cache(mhba);`
`2630`	`2630`	`}`
`2631`	`2631`
`2632`		`-static int mvumi_suspend(struct pci_dev *pdev, pm_message_t state)`
	`2632`	`+static int __maybe_unused mvumi_suspend(struct pci_dev *pdev, pm_message_t state)`
`2633`	`2633`	`{`
`2634`	`2634`	`struct mvumi_hba *mhba = NULL;`
`2635`	`2635`
`@@ -2648,7 +2648,7 @@ static int mvumi_suspend(struct pci_dev *pdev, pm_message_t state)`
`2648`	`2648`	`return 0;`
`2649`	`2649`	`}`
`2650`	`2650`
`2651`		`-static int mvumi_resume(struct pci_dev *pdev)`
	`2651`	`+static int __maybe_unused mvumi_resume(struct pci_dev *pdev)`
`2652`	`2652`	`{`
`2653`	`2653`	`int ret;`
`2654`	`2654`	`struct mvumi_hba *mhba = NULL;`