r8169: don't check WoL when powering down PHY and interface is down

hkallweit · davem330 · commit fe87bef01f9b · 2018-06-25T16:21:51.000+09:00
We can power down the PHY irregardless of WOL settings if interface
is down. So far we would have left the PHY enabled if WOL options
are set and the interface is brought down.

Signed-off-by: Heiner Kallweit &lt;hkallweit1@gmail.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
@@ -4635,7 +4635,7 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp)
 
 static bool rtl_wol_pll_power_down(struct rtl8169_private *tp)
 {
-	if (!tp->saved_wolopts)
+	if (!netif_running(tp->dev) || !tp->saved_wolopts)
 		return false;
 
 	rtl_speed_down(tp);

Original file line number	Diff line number	Diff line change
`@@ -4635,7 +4635,7 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp)`
`4635`	`4635`
`4636`	`4636`	`static bool rtl_wol_pll_power_down(struct rtl8169_private *tp)`
`4637`	`4637`	`{`
`4638`		`- if (!tp->saved_wolopts)`
	`4638`	`+ if (!netif_running(tp->dev) \|\| !tp->saved_wolopts)`
`4639`	`4639`	`return false;`
`4640`	`4640`
`4641`	`4641`	`rtl_speed_down(tp);`