Add per-view custom exception handler support #4753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What would the use case be ? |
|
In my case I want to use custom exception handler for new API not to break compatibility with legacy code. |
|
I think we'd be okay with this, yup. It'd need adding to the documention in this section... http://www.django-rest-framework.org/api-guide/views/#api-policy-instantiation-methods |
|
@tomchristie , updated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible to set custom exception handler using the
EXCEPTION_HANDLERsetting key.But it's hard to override exception handler on per-view basis.
To do this it's necessary to override
rest_framework.view.APIView.handle_exceptionmethod.What is unreasonably complex.
This PR adds ability to easily override custom exception handler on view using
rest_framework.view.APIView.get_exception_handlermethod.