Skip to content

Admin renderer urls #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2018
Merged

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented May 15, 2018

Resolves #3338 - AdminRenderer will now attempt to reverse a result's detail view URL and set that as a default if no URL is present. Additionally, the detail link/chevron will be disabled if the result has no URL, and it's column size has been set to 1, so as to consume as little space as possible.

@rpkilby rpkilby added this to the 3.9 Release milestone May 15, 2018
@rpkilby rpkilby force-pushed the admin-renderer-urls branch from dac42b6 to 90da44c Compare June 23, 2018 13:56
Attempts to reverse the result's detail view URL.
@rpkilby rpkilby force-pushed the admin-renderer-urls branch from 90da44c to 8393908 Compare June 23, 2018 14:09
@carltongibson carltongibson merged commit f89cc06 into encode:master Jul 6, 2018
@rpkilby rpkilby deleted the admin-renderer-urls branch July 6, 2018 14:11
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Make admin detail link have small width

* Disable admin detail link when no URL

* Add 'AdminRenderer.get_result_url'

Attempts to reverse the result's detail view URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants