Fix nested write of non-relational fields #6916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b512c0 to
981fb4c
Compare
981fb4c to
2d52a0f
Compare
rpkilby
suggested changes
Sep 5, 2019
* no need to change `raise_errors_on_nested_writes` signature * declare nested-model outside of the test class
8b9797c to
3801ef7
Compare
rpkilby
approved these changes
Sep 6, 2019
kevin-brown
approved these changes
Sep 10, 2019
|
Hi all, any chance on adding this in next release? We are stuck to 3.9.4 due to this issue. Do we have something pending? |
Was waiting for other members to review, but this is good to go. |
|
hope to see this in 3.10.x |
Great news. Thanks for the help and feedback @rpkilby . |
|
There should be another 3.10.x release before ~December (3.11 should roughly correspond with Django 3.0's release). |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuing work started in #6741 . This MR fixes dotted write and adds the related tests.