Skip to content

Update method override example in Schemas docs #7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2019
Merged

Update method override example in Schemas docs #7013

merged 1 commit into from
Oct 24, 2019

Conversation

ajyong
Copy link
Contributor

@ajyong ajyong commented Oct 24, 2019 •
edited
Loading

get_link() was a method in the deprecated CoreAPI-based AutoSchema class. In 3.10, DRF moved to OpenAPI schema generation, and its AutoSchema class defines get_operation() instead. I updated the code example to follow suit.

Fixes #6887

@ajyong
Update method override example in Schemas docs (#6887)
5493500 
get_link() was a method in the old CoreAPI-based AutoSchema implementation.  The new OpenAPI one defines get_operation() instead: the example code block was overlooked.
carltongibson
carltongibson approved these changes Oct 24, 2019
View reviewed changes
Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, super thanks.

@carltongibson carltongibson merged commit 4d57cd3 into encode:master Oct 24, 2019
@ajyong ajyong deleted the docs/fix-autoschema-method-override-example branch October 29, 2019 00:14
@kevin-brown kevin-brown mentioned this pull request Feb 4, 2020
Closed
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@ajyong
Update method override example in Schemas docs (encode#6887) (encode#…
e143051 
…7013)

get_link() was a method in the old CoreAPI-based AutoSchema implementation.  The new OpenAPI one defines get_operation() instead: the example code block was overlooked.
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@ajyong @sigvef
Update method override example in Schemas docs (encode#6887) (encode#…
8e039d1 
…7013)

get_link() was a method in the old CoreAPI-based AutoSchema implementation.  The new OpenAPI one defines get_operation() instead: the example code block was overlooked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema docs reference outdated methods
2 participants
@ajyong @carltongibson