Skip to content

Fix arguments of path() #7995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Fix arguments of path() #7995

merged 1 commit into from
Sep 6, 2021

Conversation

WannaFight
Copy link
Contributor

path() has no argument namespace, it has name argument

Description

Raises TypeError: _path() got an unexpected keyword argument 'namespace',
argument should be changed to name

`path()` has no argument `namespace`, it has `name` argument
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its right

@tomchristie tomchristie merged commit 9716b1b into encode:master Sep 6, 2021
@tomchristie
Copy link
Member

Thanks!

tomchristie added a commit that referenced this pull request Sep 6, 2021
tomchristie added a commit that referenced this pull request Sep 6, 2021
@tomchristie
Copy link
Member

Ooops - no.

Reverted in #8156

The name=... here isn't an argument of the path(...) function... It's an argument of the include(...) function.

sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
`path()` has no argument `namespace`, it has `name` argument
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants