Skip to content

Commit 8fcc3a3

Browse files
author
Thies C. Arntzen
committed
MFH - never initialize OCI in OCI_THREADED mode
1 parent 70376b4 commit 8fcc3a3

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

ext/oci8/oci8.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,11 +342,16 @@ PHP_MINIT_FUNCTION(oci)
342342
{
343343
zend_class_entry oci_lob_class_entry;
344344

345+
/* XXX Joe Brown says OCI_THREADED breaks windows, assuming the same is true for unix - tc
345346
#ifdef ZTS
346347
#define PHP_OCI_INIT_MODE OCI_THREADED
347348
#else
349+
*/
348350
#define PHP_OCI_INIT_MODE OCI_DEFAULT
351+
352+
/*
349353
#endif
354+
*/
350355

351356
#if OCI_USE_EMALLOC
352357
OCIInitialize(PHP_OCI_INIT_MODE, NULL, ocimalloc, ocirealloc, ocifree);

0 commit comments

Comments
 (0)