Catch empty strings right away.

Ilia Alshanetsky · Ilia Alshanetsky · commit a39201675f4c · 2006-10-11T14:19:55.000Z
diff --git a/ext/standard/string.c b/ext/standard/string.c
@@ -4851,32 +4851,38 @@ PHP_FUNCTION(str_word_count)
 		return;
 	}
 
-	if (char_list) {
-		php_charmask(char_list, char_list_len, ch TSRMLS_CC);
-	}
-	
-	p = str;
-	e = str + str_len;
-	
 	switch(type) {
 		case 1:
 		case 2:
 			array_init(return_value);
+			if (!str_len) {
+				return;
+			}
 			break;
 		case 0:
+			if (!str_len) {
+				RETURN_LONG(0);
+			}
 			/* nothing to be done */
 			break;
 		default:
 			php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid format value %ld", type);
 			RETURN_FALSE;
 	}
 
+	if (char_list) {
+		php_charmask(char_list, char_list_len, ch TSRMLS_CC);
+	}
+	
+	p = str;
+	e = str + str_len;
+
 	/* first character cannot be ' or -, unless explicitly allowed by the user */
 	if ((*p == '\'' && (!char_list || !ch['\''])) || (*p == '-' && (!char_list || !ch['-']))) {
 		p++;
 	}
 	/* last character cannot be -, unless explicitly allowed by the user */
-	if (str_len && *(e - 1) == '-' && (!char_list || !ch['-'])) {
+	if (*(e - 1) == '-' && (!char_list || !ch['-'])) {
 		e--;
 	}
 
