Updates from PR review

johndowns · johndowns · commit eaa4dedbd404 · 2022-11-18T12:41:32.000+13:00
diff --git a/quickstart/101-front-door-classic/providers.tf b/quickstart/101-front-door-classic/providers.tf
@@ -8,6 +8,7 @@ terraform {
 
     random = {
       source = "hashicorp/random"
+      version = "~> 3.4.3"
     }
   }
 
diff --git a/quickstart/101-front-door-classic/readme.md b/quickstart/101-front-door-classic/readme.md
@@ -6,8 +6,9 @@ This template deploys an [Azure Front Door (classic)](https://registry.terraform
 
 | Terraform Resource Type | Description |
 | - | - |
-| `azurerm_resource_group` | The resource group for all the deployed resources.|
+| `azurerm_resource_group` | The resource group for all the deployed resources. |
 | `azurerm_frontdoor` | The Front Door (classic). |
+| `random_id` | A random identifier generator to generate a unique Front Door resource name. |
 
 ## Variables
 
diff --git a/quickstart/101-front-door-classic/resource-group.tf b/quickstart/101-front-door-classic/resource-group.tf
@@ -2,3 +2,7 @@ resource "azurerm_resource_group" "my_resource_group" {
   name     = var.resource_group_name
   location = var.location
 }
+
+resource "random_id" "front_door_name" {
+  byte_length = 8
+}
diff --git a/quickstart/101-front-door-classic/variables.tf b/quickstart/101-front-door-classic/variables.tf
@@ -11,7 +11,3 @@ variable "resource_group_name" {
 variable "backend_address" {
   type = string
 }
-
-resource "random_id" "front_door_name" {
-  byte_length = 8
-}

Original file line number	Diff line number	Diff line change
`@@ -2,3 +2,7 @@ resource "azurerm_resource_group" "my_resource_group" {`
`2`	`2`	`name = var.resource_group_name`
`3`	`3`	`location = var.location`
`4`	`4`	`}`
	`5`	`+`
	`6`	`+resource "random_id" "front_door_name" {`
	`7`	`+ byte_length = 8`
	`8`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,3 @@ variable "resource_group_name" {`
`11`	`11`	`variable "backend_address" {`
`12`	`12`	`type = string`
`13`	`13`	`}`
`14`		`-`
`15`		`-resource "random_id" "front_door_name" {`
`16`		`- byte_length = 8`
`17`		`-}`