Skip to content

Commit bb40484

Browse files
committed
actually remove batching entirel
1 parent b890e6a commit bb40484

File tree

2 files changed

+9
-41
lines changed

2 files changed

+9
-41
lines changed

noxfile.py

Lines changed: 8 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -40,28 +40,16 @@ def parse_tox():
4040
env_matcher, dependency = line.split(":", 1)
4141
dependencies.append((env_matcher.strip(), dependency))
4242

43-
batch_jobs = {}
4443
single_jobs = []
4544

4645
for env in expand_envlist(config['tox']['envlist']):
4746
python_version, integration, framework_version, *_ = (
4847
list(env.split("-")) + [None, None]
4948
)
5049

51-
python_version_jobs = batch_jobs.setdefault(python_version, [])
52-
53-
if integration is None:
54-
python_version_jobs.append({})
55-
else:
56-
for job in python_version_jobs:
57-
if job and job.setdefault(integration, framework_version) == framework_version:
58-
break
59-
else:
60-
python_version_jobs.append({integration: framework_version})
61-
6250
single_jobs.append((python_version, integration, framework_version))
6351

64-
return dependencies, batch_jobs, single_jobs
52+
return dependencies, single_jobs
6553

6654

6755
def _format_job_name(python_version, integration, framework_version):
@@ -72,30 +60,23 @@ def _format_job_name(python_version, integration, framework_version):
7260

7361

7462
def generate_test_sessions():
75-
dependencies, batch_jobs, single_jobs = parse_tox()
63+
dependencies, single_jobs = parse_tox()
7664

77-
def add_nox_job(job_name, integrations, python_version, deps):
65+
def add_nox_job(job_name, integration, python_version, deps):
7866
def func(session, fast=False):
7967
if not fast:
8068
session.install("-U", "pip")
8169
session.install("-e", ".")
8270
session.install("-r", "test-requirements.txt")
8371

8472
if deps:
85-
session.install(
86-
*deps,
87-
# Necessary to be able to specify double-requirements
88-
"--use-feature=2020-resolver",
89-
)
73+
session.install(*deps)
9074

9175
session.env['COVERAGE_FILE'] = ".coverage-{job_name}".format(job_name=job_name)
9276
session.run(
9377
"pytest",
94-
*[
95-
"tests/integrations/{integration}".format(integration=integration)
96-
if integration else "tests/"
97-
for integration in integrations
98-
],
78+
"tests/integrations/{integration}".format(integration=integration)
79+
if integration else "tests/",
9980
*session.posargs
10081
)
10182

@@ -110,20 +91,7 @@ def func(session, fast=False):
11091
job_name = _format_job_name(python_version,integration,framework_version)
11192
deps = list(find_dependencies(dependencies, job_name))
11293

113-
add_nox_job("test-{job_name}".format(job_name=job_name), [integration], python_version, deps)
114-
115-
for python_version, batches in batch_jobs.items():
116-
for batch_name, integrations in enumerate(batches):
117-
job_name = "batchtest-{python_version}-{batch_name}".format(python_version=python_version, batch_name=batch_name)
118-
deps = []
119-
for integration, framework_version in integrations.items():
120-
deps.extend(find_dependencies(
121-
dependencies,
122-
_format_job_name(python_version, integration, framework_version)
123-
))
124-
125-
add_nox_job(job_name, integrations, python_version, deps)
126-
94+
add_nox_job("test-{job_name}".format(job_name=job_name), integration, python_version, deps)
12795

12896
@nox.session(python="3.8")
12997
def linters(session):
@@ -143,7 +111,7 @@ def travis_test(session):
143111
installed_base_deps = False
144112
for name, f in globals().items():
145113
python = "pypy" if travis_python == "pypy" else "py{}".format(travis_python)
146-
if name.startswith("batchtest-{python}".format(python=python)):
114+
if name.startswith("test-{python}".format(python=python)):
147115
f(session, fast=installed_base_deps)
148116
installed_base_deps = True
149117

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ deps =
171171
trytond-4.8: trytond>=4.8,<4.9
172172
trytond-4.6: trytond>=4.6,<4.7
173173

174-
redis: fakeredis
174+
redis: fakeredis>=1.0
175175

176176
rediscluster-1: redis-py-cluster>=1.0.0,<2.0.0
177177
rediscluster-2: redis-py-cluster>=2.0.0,<3.0.0

0 commit comments

Comments
 (0)