Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eslint/eslint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.40.0
Choose a base ref
...
head repository: eslint/eslint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.41.0
Choose a head ref
  • 17 commits
  • 33 files changed
  • 10 contributors

Commits on May 7, 2023

  1. 1 Configuration menu
    Copy the full SHA
    4caa344 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. perf: Store indent descriptors in a plain array (#17148)

    * perf: Store indent descriptors in a plain array
    
    * Fix return type JSDoc
    
    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    
    ---------
    
    Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
    fasttime and mdjermanovic authored May 8, 2023
    1 Configuration menu
    Copy the full SHA
    918b0fd View commit details
    Browse the repository at this point in the history
  2. fix: switch grapheme-splitter to graphemer (#17160)

    * fix: improve `getGraphemeCount`
    
    * Fix
    
    * Fix
    
    * Use `Graphemer` only
    fisker authored May 8, 2023
    1 Configuration menu
    Copy the full SHA
    9682d66 View commit details
    Browse the repository at this point in the history
  3. docs: fix license to reflect relicensing of jshint (#17165)

    Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
    stbischof authored May 8, 2023
    1 Configuration menu
    Copy the full SHA
    b68346b View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    b1516db View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. fix: validate ignorePatterns constructor option in FlatESLint cla…

    …ss (#17139)
    
    * fix: validate `ignorePatterns` constructor option in `FlatESLint` class
    
    * disallow string value
    mdjermanovic authored May 9, 2023
    1 Configuration menu
    Copy the full SHA
    0c415cd View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    7f183e0 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. 1 Configuration menu
    Copy the full SHA
    8bf5505 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. docs: Update README

    GitHub Actions Bot committed May 13, 2023
    1 Configuration menu
    Copy the full SHA
    7709b14 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. fix: unify LintMessage type (#17076)

    * Update LintMessage type to reflect implementation
    
    I made three changes to `LintMessage` and `SuppressedLintMessage`
    
    1. Many places that create `LintMessage`s don't set `fatal`, so I made
       it optional. This would be a breaking change if we made types part of
       our exports, but in this case I believe it's updating JSDoc
       documentation to reflect reality.
    2. Added an optional `messageId` property that's set by reports from rules.
    3. Added an optional, nullable `nodeType` property.
        - Reports from rules set it to a value.
        - `applyDirectives()` explicitly sets it to `null` for unused
          disable directives.
        - `Linter`'s `createLintingProblem()` explicitly sets it to `null`.
    
    * Add missing LintResult type import
    
    * Use LintMessage type
    
    All of these previously referenced a `Problem` type that does not have a
    definition.
    
    * Replace ReportInfo type with LintMessage type
    
    `ReportInfo` was defined within `report-translator.js` to be very
    similar to `LintMessage`. It had one extra property, `source`, which
    wasn't ever set, so it would've been removed anyway. In
    `Linter.runRules()`, the return value from `reportTranslator()` gets
    pushed into a `lintingProblems` array and returned, and the return type
    annotation is `LintMessage[]`, which gives me confidence that
    `ReportInfo` was intended to be the same type as `LintMessage`
    elsewhere.
    
    * Make ruleId required but nullable
    
    Originally, we talked about the reverse - making `ruleId` optional but
    non-nullable and relying on `report-translator.js`'s `createProblem()`
    to normalize it. However, the `LintMessage` type would differ from
    `createProblem()`'s return value only by `null` vs `undefined` for
    `ruleId`. So instead, I made `ruleId` required but nullable and
    explicitly set it to `null` in the few remaining places that didn't
    already.
    
    * Add missing null nodeTypes
    
    `LintMessage.nodeType` is currently defined as required but nullable.
    Actual implementations explicitly set it to `null` in a couple places
    and omit it in several.
    
    After discussion in #16968, we initially leaned toward making it
    non-nullable but optional. I pursued that, but it resulted in slightly
    more runtime code changes, including some branching in
    `report-translator` to set it conditionally.
    
    Instead, I'm presenting the opposite solution of updating the remaining
    implementations to match the existing type definition by explicitly
    setting `nodeType` to `null`.
    
    * Update LintMessage docs
    
    This updates existing documented properties to match the updated `LintMessage`
    type and implementations.
    
    `messageId`, `nodeType`, and `suppressions` remain undocumented.
    btmills authored May 16, 2023
    1 Configuration menu
    Copy the full SHA
    94da96c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. feat: change default ignore pattern to **/node_modules/ in flat con…

    …fig (#17184)
    
    * feat: change default ignore pattern to `**/node_modules/` in flat config
    
    Fixes #17113
    
    * update warning message
    mdjermanovic authored May 17, 2023
    1 Configuration menu
    Copy the full SHA
    880a431 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. 1 Configuration menu
    Copy the full SHA
    ddc5291 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. 1 Configuration menu
    Copy the full SHA
    4f5440d View commit details
    Browse the repository at this point in the history
  2. chore: package.json update for @eslint/js release

    ESLint Jenkins committed May 19, 2023
    1 Configuration menu
    Copy the full SHA
    95c3007 View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    f43216a View commit details
    Browse the repository at this point in the history
  4. Build: changelog update for 8.41.0

    ESLint Jenkins committed May 19, 2023
    1 Configuration menu
    Copy the full SHA
    acd615c View commit details
    Browse the repository at this point in the history
  5. 8.41.0

    ESLint Jenkins committed May 19, 2023
    1 Configuration menu
    Copy the full SHA
    7a2a0be View commit details
    Browse the repository at this point in the history
Loading