From 36fdd85d7a448d5b82e2618d5bfbebe948ca8032 Mon Sep 17 00:00:00 2001 From: Bryan Mishkin <698306+bmish@users.noreply.github.com> Date: Fri, 15 Oct 2021 08:51:23 -0400 Subject: [PATCH 1/5] Docs: Improve CHANGELOG for v4 (#217) --- CHANGELOG.md | 68 ++++++++++++++++++++++++++++++++++++---------------- 1 file changed, 48 insertions(+), 20 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2eea00da..6a1f4475 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,12 +6,42 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). #### [v4.0.0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-3...v4.0.0) +This release is identical to v4.0.0-3. Summary of changes: + +- Breaking: Enable additional `recommended` rules for v4 [`#152`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/152) +- Breaking: Support TypeScript rules [`#197`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/197) +- Breaking: Support ESM rules [`#177`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/177) +- Breaking: Add `fixer-return` to `rules` preset [`#199`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/199) +- Breaking: Add `hasSuggestions` property to `meta-property-ordering` rule [`#119`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/119) +- Breaking: Drop support for Node 10, 13, 15 [`#151`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/151) +- Breaking: Drop support for old minor versions of Node 12 and 14 [`#212`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/212) +- Breaking: Reduce false positives by only detecting function-style rules when function returns an object [`#211`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/211) +- Breaking: Update `fixer-return` and `prefer-replace-text` rules to also apply to suggestion fixer functions [`#194`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/194) +- Breaking: Update `no-missing-placeholders`, `no-unused-placeholders`, `prefer-message-ids`, `prefer-placeholders` rules to also apply to suggestion messages [`#196`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/196) +- Breaking: Update `report-message-format` to also apply to suggestion messages [`#195`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/195) +- Fix: False negative with TypeScript rules that don't have type parameters (fixes #202) [`#209`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/209) +- Fix: Only consider functions with a single argument as function-style rules [`#213`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/213) +- Build: test on ESLint v8 (fixes #175) [`#186`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/186) +- Chore: Fix markdownlint glob path [`#200`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/200) +- Chore: Switch to release-it [`#131`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/131) +- Chore: fix release-it config [`124909c`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/124909c16c729756e0197be1943ab26142a39fc2) +- Chore: release-it config [`894d7b0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/894d7b0f115ca0c45c4938da594da3d05614d87f) +- Chore: `require-meta-docs-url` allows prereleases [`8fe1017`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/8fe10179a670971f5ddfc59d64354bce2c7c5151) +- Chore: upgrade `@ts-eslint/parser` to v5 [`#206`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/206) +- Chore: upgrade `eslint-utils` to v3 [`#148`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/148) +- Chore: upgrade dev deps (fixes #188) [`#198`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/198) +- Chore: upgrade `eslint-plugin-unicorn` to v36 [`#187`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/187) +- Docs: Improve README headers [`#208`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/208) +- Docs: Move preset list into table in README [`#205`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/205) +- Docs: add example of using rule/test presets in overrides to README [`#204`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/204) +- Docs: add toc in readme [`#207`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/207) + #### [v4.0.0-3](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-2...v4.0.0-3) > 15 October 2021 -- Fix: Only consider functions with a single argument as function-style rules [`#213`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/213) - Breaking: Reduce false positives by only detecting function-style rules when function returns an object [`#211`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/211) +- Fix: Only consider functions with a single argument as function-style rules [`#213`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/213) - Release 4.0.0-3 [`64e8da6`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/64e8da6b4453895b988bfe0813e5ea2886e9fcf5) #### [v4.0.0-2](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-1...v4.0.0-2) @@ -20,45 +50,43 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). - Breaking: Drop support for old minor versions of Node 12 and 14 [`#212`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/212) - Fix: False negative with TypeScript rules that don't have type parameters (fixes #202) [`#209`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/209) -- Chore: upgrade @ts-eslint/parser to v5 [`#206`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/206) +- Upgrade @ts-eslint/parser to v5 [`#206`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/206) +- Upgrade: eslint-plugin-unicorn to v37 [`#203`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/203) - Docs: Improve README headers [`#208`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/208) -- Docs: add toc in readme [`#207`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/207) - Docs: Move preset list into table in README [`#205`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/205) -- docs: add example of using rule/test presets in overrides to README [`#204`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/204) -- Upgrade: eslint-plugin-unicorn to v37 [`#203`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/203) -- Fix: False negative with TypeScript rules that don't have type parameters (fixes #202) (#209) [`#202`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/202) +- Docs: add example of using rule/test presets in overrides to README [`#204`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/204) +- Docs: add toc in readme [`#207`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/207) - Release 4.0.0-2 [`f79f6ac`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/f79f6acc710dfb59ded7c6bc7d79b33469713d83) #### [v4.0.0-1](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-0...v4.0.0-1) > 11 October 2021 -- Release 4.0.0-1 [`887b5d0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/887b5d0cc5beee7046d953a9fc8e87203920cf2a) - Chore: fix release-it config [`124909c`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/124909c16c729756e0197be1943ab26142a39fc2) - Chore: require-meta-docs-url allows prereleases [`8fe1017`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/8fe10179a670971f5ddfc59d64354bce2c7c5151) +- Release 4.0.0-1 [`887b5d0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/887b5d0cc5beee7046d953a9fc8e87203920cf2a) #### [v4.0.0-0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v3.6.1...v4.0.0-0) > 11 October 2021 -- Breaking: Add support for TypeScript rules [`#197`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/197) -- Build: test on eslint v8 (fixes #175) [`#186`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/186) -- Chore: Fix markdownlint glob path [`#200`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/200) -- Breaking: Add `fixer-return` to `rules` preset [`#199`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/199) -- Chore: Switch to release-it [`#131`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/131) -- Chore: upgrade dev deps (fixes #188) [`#198`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/198) + - Breaking: Enable additional `recommended` rules for v4 [`#152`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/152) +- Breaking: Support TypeScript rules [`#197`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/197) +- Breaking: Support ESM rules [`#177`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/177) +- Breaking: Add `fixer-return` to `rules` preset [`#199`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/199) +- Breaking: Add `hasSuggestions` property to `meta-property-ordering` rule [`#119`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/119) +- Breaking: Drop support for Node 10, 13, 15 [`#151`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/151) - Breaking: Update `fixer-return` and `prefer-replace-text` rules to also apply to suggestion fixer functions [`#194`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/194) - Breaking: Update `no-missing-placeholders`, `no-unused-placeholders`, `prefer-message-ids`, `prefer-placeholders` rules to also apply to suggestion messages [`#196`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/196) - Breaking: Update `report-message-format` to also apply to suggestion messages [`#195`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/195) -- Breaking: Add hasSuggestions property to meta-property-ordering rule [`#119`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/119) -- Breaking: Support ESM rules [`#177`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/177) -- chore(dev-deps): upgrade eslint-plugin-unicorn to v36 [`#187`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/187) -- Chore: Update `eslint-utils` to v3 [`#148`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/148) -- Breaking: Drop support for Node 10, 13, 15 [`#151`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/151) -- Build: test on eslint v8 (fixes #175) (#186) [`#175`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/175) -- Chore: upgrade dev deps (fixes #188) (#198) [`#188`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/188) +- Build: test on eslint v8 (fixes #175) [`#186`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/186) +- Chore: Fix markdownlint glob path [`#200`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/200) +- Chore: Switch to release-it [`#131`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/131) - Chore: release-it config [`894d7b0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/894d7b0f115ca0c45c4938da594da3d05614d87f) +- Chore: upgrade `eslint-utils` to v3 [`#148`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/148) +- Chore: upgrade dev deps (fixes #188) [`#198`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/198) +- Chore: upgrade eslint-plugin-unicorn to v36 [`#187`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/187) - Release 4.0.0-0 [`f4b984c`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/f4b984c16b0035ceba4d5973d851ad535f72664e) #### [v3.6.1](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v3.6.0...v3.6.1) From c3d85ab53b49a3b3eccd817322168c0158e306e1 Mon Sep 17 00:00:00 2001 From: Bryan Mishkin <698306+bmish@users.noreply.github.com> Date: Fri, 15 Oct 2021 08:56:01 -0400 Subject: [PATCH 2/5] Fix: Avoid crash when provided suggestions array has non-object (#216) --- lib/utils.js | 7 ++++-- tests/lib/utils.js | 63 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 68 insertions(+), 2 deletions(-) diff --git a/lib/utils.js b/lib/utils.js index 77779e7c..edc31c43 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -467,14 +467,17 @@ module.exports = { // Suggestion messages ...((reportInfo.suggest && reportInfo.suggest.elements) || []) .map(suggestObjNode => { + if (suggestObjNode.type !== 'ObjectExpression') { + // Ignore non-objects (like variables or function calls). + return null; + } return { messageId: findObjectPropertyValueByKeyName(suggestObjNode, 'messageId'), message: findObjectPropertyValueByKeyName(suggestObjNode, 'desc'), // Note: suggestion message named `desc` data: findObjectPropertyValueByKeyName(suggestObjNode, 'data'), fix: findObjectPropertyValueByKeyName(suggestObjNode, 'fix'), }; - } - ), + }).filter(item => item !== null), ]; }, diff --git a/tests/lib/utils.js b/tests/lib/utils.js index e4d9240e..2bc3b5cf 100644 --- a/tests/lib/utils.js +++ b/tests/lib/utils.js @@ -626,6 +626,7 @@ describe('utils', () => { describe('collectReportViolationAndSuggestionData', () => { const CASES = [ { + // One suggestion. code: ` context.report({ node: {}, @@ -656,6 +657,68 @@ describe('utils', () => { }, ], }, + { + // Suggestions using an array variable. + code: ` + context.report({ + node: {}, + message: "message1", + messageId: "messageId1", + data: { foo: 'hello' }, + fix(fixer) {}, + suggest: SUGGESTIONS + }); + `, + shouldMatch: [ + { + message: { type: 'Literal', value: 'message1' }, + messageId: { type: 'Literal', value: 'messageId1' }, + data: { type: 'ObjectExpression', properties: [{ key: { name: 'foo' } }] }, + fix: { type: 'FunctionExpression' }, + }, + ], + }, + { + // Suggestions using array item variables. + code: ` + context.report({ + node: {}, + message: "message1", + messageId: "messageId1", + data: { foo: 'hello' }, + fix(fixer) {}, + suggest: [ SUGGEST_1, SUGGEST_2 ] + }); + `, + shouldMatch: [ + { + message: { type: 'Literal', value: 'message1' }, + messageId: { type: 'Literal', value: 'messageId1' }, + data: { type: 'ObjectExpression', properties: [{ key: { name: 'foo' } }] }, + fix: { type: 'FunctionExpression' }, + }, + ], + }, + { + // No suggestions. + code: ` + context.report({ + node: {}, + message: "message1", + messageId: "messageId1", + data: { foo: 'hello' }, + fix(fixer) {}, + }); + `, + shouldMatch: [ + { + message: { type: 'Literal', value: 'message1' }, + messageId: { type: 'Literal', value: 'messageId1' }, + data: { type: 'ObjectExpression', properties: [{ key: { name: 'foo' } }] }, + fix: { type: 'FunctionExpression' }, + }, + ], + }, ]; it('behaves correctly', () => { From e3587e03b61c48627f13b93b5675ed81ae64910b Mon Sep 17 00:00:00 2001 From: Bryan Mishkin <698306+bmish@users.noreply.github.com> Date: Fri, 15 Oct 2021 09:13:51 -0400 Subject: [PATCH 3/5] Docs: Add missing date in changelog (#218) --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a1f4475..ca6692a7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). #### [v4.0.0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-3...v4.0.0) +> 15 October 2021 + This release is identical to v4.0.0-3. Summary of changes: - Breaking: Enable additional `recommended` rules for v4 [`#152`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/152) From 08df92755f45b7d8f16a9efc7dd7514cb1ab9cf2 Mon Sep 17 00:00:00 2001 From: Bryan Mishkin <698306+bmish@users.noreply.github.com> Date: Fri, 15 Oct 2021 09:14:31 -0400 Subject: [PATCH 4/5] Fix: Handle `meta: {} as const` for TypeScript rules (#219) --- lib/utils.js | 3 ++- tests/lib/utils.js | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/utils.js b/lib/utils.js index edc31c43..3b27af1d 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -97,7 +97,8 @@ function collectInterestingProperties (properties, interestingKeys) { return properties.reduce((parsedProps, prop) => { const keyValue = module.exports.getKeyName(prop); if (interestingKeys.has(keyValue)) { - parsedProps[keyValue] = prop.value; + // In TypeScript, unwrap any usage of `{} as const`. + parsedProps[keyValue] = prop.value.type === 'TSAsExpression' ? prop.value.expression : prop.value; } return parsedProps; }, {}); diff --git a/tests/lib/utils.js b/tests/lib/utils.js index 2bc3b5cf..bca41252 100644 --- a/tests/lib/utils.js +++ b/tests/lib/utils.js @@ -139,6 +139,13 @@ describe('utils', () => { isNewStyle: true, }, + // Util function with "{} as const". + 'export default createESLintRule({ create() {}, meta: {} as const });': { + create: { type: 'FunctionExpression' }, + meta: { type: 'ObjectExpression' }, + isNewStyle: true, + }, + // Util function from util object 'export default util.createRule({ create() {}, meta: {} });': { create: { type: 'FunctionExpression' }, From 51fa5bb6b033321de0565ccf3d6ddfdd03bddd48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=94=AF=E7=84=B6?= Date: Fri, 15 Oct 2021 21:27:07 +0800 Subject: [PATCH 5/5] Release 4.0.1 --- CHANGELOG.md | 90 ++++++++++++++++++++-------------------------------- package.json | 2 +- 2 files changed, 36 insertions(+), 56 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ca6692a7..d623be9b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,46 +4,30 @@ All notable changes to this project will be documented in this file. Dates are d Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). -#### [v4.0.0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-3...v4.0.0) +#### [v4.0.1](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.1...v4.0.1) + +#### [v4.0.1](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0...v4.0.1) > 15 October 2021 -This release is identical to v4.0.0-3. Summary of changes: +- Fix: Handle `meta: {} as const` for TypeScript rules [`#219`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/219) +- Docs: Add missing date in changelog [`#218`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/218) +- Fix: Avoid crash when provided suggestions array has non-object [`#216`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/216) +- Docs: Improve CHANGELOG for v4 [`#217`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/217) +- Release 4.0.1 [`258bc5e`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/258bc5e0f9c7165126d3c082579749c2fdd17057) -- Breaking: Enable additional `recommended` rules for v4 [`#152`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/152) -- Breaking: Support TypeScript rules [`#197`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/197) -- Breaking: Support ESM rules [`#177`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/177) -- Breaking: Add `fixer-return` to `rules` preset [`#199`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/199) -- Breaking: Add `hasSuggestions` property to `meta-property-ordering` rule [`#119`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/119) -- Breaking: Drop support for Node 10, 13, 15 [`#151`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/151) -- Breaking: Drop support for old minor versions of Node 12 and 14 [`#212`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/212) -- Breaking: Reduce false positives by only detecting function-style rules when function returns an object [`#211`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/211) -- Breaking: Update `fixer-return` and `prefer-replace-text` rules to also apply to suggestion fixer functions [`#194`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/194) -- Breaking: Update `no-missing-placeholders`, `no-unused-placeholders`, `prefer-message-ids`, `prefer-placeholders` rules to also apply to suggestion messages [`#196`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/196) -- Breaking: Update `report-message-format` to also apply to suggestion messages [`#195`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/195) -- Fix: False negative with TypeScript rules that don't have type parameters (fixes #202) [`#209`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/209) -- Fix: Only consider functions with a single argument as function-style rules [`#213`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/213) -- Build: test on ESLint v8 (fixes #175) [`#186`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/186) -- Chore: Fix markdownlint glob path [`#200`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/200) -- Chore: Switch to release-it [`#131`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/131) -- Chore: fix release-it config [`124909c`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/124909c16c729756e0197be1943ab26142a39fc2) -- Chore: release-it config [`894d7b0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/894d7b0f115ca0c45c4938da594da3d05614d87f) -- Chore: `require-meta-docs-url` allows prereleases [`8fe1017`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/8fe10179a670971f5ddfc59d64354bce2c7c5151) -- Chore: upgrade `@ts-eslint/parser` to v5 [`#206`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/206) -- Chore: upgrade `eslint-utils` to v3 [`#148`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/148) -- Chore: upgrade dev deps (fixes #188) [`#198`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/198) -- Chore: upgrade `eslint-plugin-unicorn` to v36 [`#187`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/187) -- Docs: Improve README headers [`#208`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/208) -- Docs: Move preset list into table in README [`#205`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/205) -- Docs: add example of using rule/test presets in overrides to README [`#204`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/204) -- Docs: add toc in readme [`#207`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/207) +#### [v4.0.0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-3...v4.0.0) + +> 15 October 2021 + +- Release 4.0.0 [`fe4bca3`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/fe4bca3b73405428c566760069cbf338db2b9202) #### [v4.0.0-3](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-2...v4.0.0-3) > 15 October 2021 -- Breaking: Reduce false positives by only detecting function-style rules when function returns an object [`#211`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/211) - Fix: Only consider functions with a single argument as function-style rules [`#213`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/213) +- Breaking: Reduce false positives by only detecting function-style rules when function returns an object [`#211`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/211) - Release 4.0.0-3 [`64e8da6`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/64e8da6b4453895b988bfe0813e5ea2886e9fcf5) #### [v4.0.0-2](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-1...v4.0.0-2) @@ -52,43 +36,45 @@ This release is identical to v4.0.0-3. Summary of changes: - Breaking: Drop support for old minor versions of Node 12 and 14 [`#212`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/212) - Fix: False negative with TypeScript rules that don't have type parameters (fixes #202) [`#209`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/209) -- Upgrade @ts-eslint/parser to v5 [`#206`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/206) -- Upgrade: eslint-plugin-unicorn to v37 [`#203`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/203) +- Chore: upgrade @ts-eslint/parser to v5 [`#206`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/206) - Docs: Improve README headers [`#208`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/208) -- Docs: Move preset list into table in README [`#205`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/205) -- Docs: add example of using rule/test presets in overrides to README [`#204`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/204) - Docs: add toc in readme [`#207`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/207) +- Docs: Move preset list into table in README [`#205`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/205) +- docs: add example of using rule/test presets in overrides to README [`#204`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/204) +- Upgrade: eslint-plugin-unicorn to v37 [`#203`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/203) +- Fix: False negative with TypeScript rules that don't have type parameters (fixes #202) (#209) [`#202`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/202) - Release 4.0.0-2 [`f79f6ac`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/f79f6acc710dfb59ded7c6bc7d79b33469713d83) #### [v4.0.0-1](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v4.0.0-0...v4.0.0-1) > 11 October 2021 +- Release 4.0.0-1 [`887b5d0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/887b5d0cc5beee7046d953a9fc8e87203920cf2a) - Chore: fix release-it config [`124909c`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/124909c16c729756e0197be1943ab26142a39fc2) - Chore: require-meta-docs-url allows prereleases [`8fe1017`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/8fe10179a670971f5ddfc59d64354bce2c7c5151) -- Release 4.0.0-1 [`887b5d0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/887b5d0cc5beee7046d953a9fc8e87203920cf2a) #### [v4.0.0-0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v3.6.1...v4.0.0-0) > 11 October 2021 - -- Breaking: Enable additional `recommended` rules for v4 [`#152`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/152) -- Breaking: Support TypeScript rules [`#197`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/197) -- Breaking: Support ESM rules [`#177`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/177) +- Breaking: Add support for TypeScript rules [`#197`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/197) +- Build: test on eslint v8 (fixes #175) [`#186`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/186) +- Chore: Fix markdownlint glob path [`#200`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/200) - Breaking: Add `fixer-return` to `rules` preset [`#199`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/199) -- Breaking: Add `hasSuggestions` property to `meta-property-ordering` rule [`#119`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/119) -- Breaking: Drop support for Node 10, 13, 15 [`#151`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/151) +- Chore: Switch to release-it [`#131`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/131) +- Chore: upgrade dev deps (fixes #188) [`#198`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/198) +- Breaking: Enable additional `recommended` rules for v4 [`#152`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/152) - Breaking: Update `fixer-return` and `prefer-replace-text` rules to also apply to suggestion fixer functions [`#194`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/194) - Breaking: Update `no-missing-placeholders`, `no-unused-placeholders`, `prefer-message-ids`, `prefer-placeholders` rules to also apply to suggestion messages [`#196`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/196) - Breaking: Update `report-message-format` to also apply to suggestion messages [`#195`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/195) -- Build: test on eslint v8 (fixes #175) [`#186`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/186) -- Chore: Fix markdownlint glob path [`#200`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/200) -- Chore: Switch to release-it [`#131`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/131) +- Breaking: Add hasSuggestions property to meta-property-ordering rule [`#119`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/119) +- Breaking: Support ESM rules [`#177`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/177) +- chore(dev-deps): upgrade eslint-plugin-unicorn to v36 [`#187`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/187) +- Chore: Update `eslint-utils` to v3 [`#148`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/148) +- Breaking: Drop support for Node 10, 13, 15 [`#151`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/151) +- Build: test on eslint v8 (fixes #175) (#186) [`#175`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/175) +- Chore: upgrade dev deps (fixes #188) (#198) [`#188`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/188) - Chore: release-it config [`894d7b0`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/894d7b0f115ca0c45c4938da594da3d05614d87f) -- Chore: upgrade `eslint-utils` to v3 [`#148`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/148) -- Chore: upgrade dev deps (fixes #188) [`#198`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/198) -- Chore: upgrade eslint-plugin-unicorn to v36 [`#187`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/187) - Release 4.0.0-0 [`f4b984c`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/f4b984c16b0035ceba4d5973d851ad535f72664e) #### [v3.6.1](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v3.6.0...v3.6.1) @@ -228,22 +214,16 @@ This release is identical to v4.0.0-3. Summary of changes: - Build: update package.json and changelog for v3.0.1 [`0b4bcaf`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/0b4bcaf8a168bd747f2334015ef42d8f169c1dcb) - chore: fix failing tests [`e6aa71f`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/e6aa71f8b018c109ab86ca887f70b253a3e312a3) -### [v3.0.0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v2.3.1...v3.0.0) +### [v3.0.0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v2.3.0...v3.0.0) > 8 April 2021 - Breaking: change test-case-property-ordering default options (fixes #79) [`#93`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/93) - Breaking: drop eslint < 7 & node.js < 10 [`#95`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/95) +- Docs: Grammar in `require-meta-schema.md` [`#103`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/103) - Breaking: change test-case-property-ordering default options (fixes #79) (#93) [`#79`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/79) - Build: update package.json and changelog for v3.0.0 [`02c1f34`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/02c1f347f2f0881e364724a4fce69e9da2ce9313) -#### [v2.3.1](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v2.3.0...v2.3.1) - -> 8 April 2021 - -- Docs: Grammar in `require-meta-schema.md` [`#103`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/103) -- Build: update package.json and changelog for v2.3.1 [`d95a1a6`](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/commit/d95a1a666be795d7b0e117c34c591559c512ae03) - #### [v2.3.0](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/compare/v2.2.2...v2.3.0) > 22 June 2020 diff --git a/package.json b/package.json index 7d768b41..b3783e58 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "eslint-plugin-eslint-plugin", - "version": "4.0.0", + "version": "4.0.1", "description": "An ESLint plugin for linting ESLint plugins", "author": "Teddy Katz", "main": "lib/index.js",