Skip to content

No Touchscreen + expander: Compilation error #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rolloo opened this issue Jun 28, 2024 · 3 comments · Fixed by #66
Closed

No Touchscreen + expander: Compilation error #65

rolloo opened this issue Jun 28, 2024 · 3 comments · Fixed by #66

Comments

@rolloo
Copy link

rolloo commented Jun 28, 2024

Hello,
I am trying to build an example for Adafruit Qualia ESP32-S3 + Round RGB TTL TFT Display - 4" 720x720 - No Touchscreen

  • Compilation error: 'ESP_PANEL_TOUCH_BUS_HOST' was not declared in this scope

ESP_Panel_Board_Custom.h

#define ESP_PANEL_USE_TOUCH             (0) 
#define ESP_PANEL_USE_EXPANDER          (1)
Lzw655 added a commit that referenced this issue Jul 1, 2024
@Lzw655
fix(panel): init expander host with correct macro
7c3d462 
Closes #65
@Lzw655 Lzw655 mentioned this issue Jul 1, 2024
Merged
@Lzw655
Copy link
Collaborator

Lzw655 commented Jul 1, 2024 •
edited
Loading

Hi @rolloo,

Sorry, there's a bug in the library. When setting up the expander's host, it should use the macro ESP_PANEL_EXPANDER_HOST_ID instead of ESP_PANEL_TOUCH_BUS_HOST.

The PR fixes this problem. Can you assist me in testing it?

@rolloo
Copy link
Author

rolloo commented Jul 1, 2024

Hi @Lzw655

Compilation error: invalid conversion from 'int' to 'i2c_port_t' [-fpermissive]

  328 |     #define ESP_PANEL_EXPANDER_HOST_ID          (0)     // Typically set to 0
      |                                                 ~^~
      |                                                  |
      |                                                  int

@Lzw655
Copy link
Collaborator

Lzw655 commented Jul 2, 2024

😂 Sorry, the macro should be ESP_PANEL_EXPANDER_HOST. Fixed in the new commit, please try again.

@Lzw655 Lzw655 closed this as completed in #66 Jul 7, 2024
@Lzw655 Lzw655 closed this as completed in 291b060 Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(panel): init expander host with correct macro esp-arduino-libs/ESP32_Display_Panel
2 participants
@rolloo @Lzw655