From 0839217d189c89f558c6c976af2b2247657605a1 Mon Sep 17 00:00:00 2001 From: Joey Babcock Date: Sat, 1 Jul 2017 16:51:59 -0700 Subject: [PATCH 1/2] Edit comments for clarity I was a little confused reading what this sketch did the first time so I attempted to edit these for clarity. --- .../SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino b/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino index 1464fd5dbfb..5dd9e25a565 100644 --- a/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino +++ b/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino @@ -12,9 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. -// Sketch shows how SimpleBLE to advertise the name of the device and change it on button press -// Usefull if you want to advertise some short message -// Button is attached between GPIO 0 and GND and modes are switched with each press +// Sketch shows how to use SimpleBLE to advertise the name of the device and change it on the press of a button +// Useful if you want to advertise some sort of message +// Button is attached between GPIO 0 and GND, and the name changes with each button press #include "SimpleBLE.h" SimpleBLE ble; From c198222b31b4da52865040f80f6caa97b120cde3 Mon Sep 17 00:00:00 2001 From: Joey Babcock Date: Sat, 1 Jul 2017 16:54:45 -0700 Subject: [PATCH 2/2] code edits as well Grammar fixes for some parts of the code as well --- .../SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino b/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino index 5dd9e25a565..249363d4893 100644 --- a/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino +++ b/libraries/SimpleBLE/examples/SimpleBleDevice/SimpleBleDevice.ino @@ -14,13 +14,13 @@ // Sketch shows how to use SimpleBLE to advertise the name of the device and change it on the press of a button // Useful if you want to advertise some sort of message -// Button is attached between GPIO 0 and GND, and the name changes with each button press +// Button is attached between GPIO 0 and GND, and the device name changes each time the button is pressed #include "SimpleBLE.h" SimpleBLE ble; void onButton(){ - String out = "BLE32 at: "; + String out = "BLE32 name: "; out += String(millis() / 1000); Serial.println(out); ble.begin(out); @@ -33,7 +33,7 @@ void setup() { Serial.print("ESP32 SDK: "); Serial.println(ESP.getSdkVersion()); ble.begin("ESP32 SimpleBLE"); - Serial.println("Press the button to change the device name"); + Serial.println("Press the button to change the device's name"); } void loop() {