Skip to content

Seeking Feedback: Merging umbrella packages into a unified package #95

@ricmoo

Description

@ricmoo

Hey all!

Sending out a quick request for feedback.

I'm thinking of merging all the umbrella packages into a single ethers package.

The advantages

  • Greatly simplify the production of distribution packages
  • Make testing in PhantomJS more reliable
  • Easier to update bug fixes and features in the ethers-utils that other libraries depend on
  • Simplify refactoring
  • Package versions can more accurately follow semver

This will be a major version change to prevent any existing users' dependencies on sub-packages from breaking. The sub-package package.json will be removed as well and all packages will correctly link against the internal files.

The original reason for splitting the package was that some users wanted smaller, more modular packages because their Webpack packages were too big, but I suspect they didn't know how to configure Webpack properly (I use Browserify, which automatically prunes unused files). If someone who uses Webpack could comment on this, I'd appreciate some feedback. For example, in browserify:

var providers = require('ethers/providers');

Will only pull in the relevant parts of the ethers project, where as I believe the other users' were using:

var providers = require('ethers').providers;

which would pull in the entire package.

The documentation will be updated to include the require statements that can be reliably used between major versions, (e.g. require('ethers/utils')).

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussionQuestions, feedback and general information.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions