Merge pull request #17 from pengpeng11/deadlockFix

ganeshramc · web-flow · commit e88b542ae25b · 2019-05-10T15:14:02.000-07:00
Fix deadlock issue.
diff --git a/PayPalCheckoutSdk/Core/PaypalHttpClient.cs b/PayPalCheckoutSdk/Core/PaypalHttpClient.cs
@@ -57,8 +57,11 @@ public void Inject(HttpRequest request)
 
             private HttpResponse fetchAccessToken()
             {
+                //create a new client for acceess token.
+                HttpClient AccessTokenClient = new HttpClient(environment);
                 AccessTokenRequest request = new AccessTokenRequest(environment, refreshToken);
-                var executeTask = this.client.Execute(request);
+                //make fetch access token call sync to avoid deadlock.
+                Task<HttpResponse> executeTask = Task.Run<HttpResponse>(async () => await AccessTokenClient.Execute(request));
                 return executeTask.Result;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,11 @@ public void Inject(HttpRequest request)`
`57`	`57`
`58`	`58`	`private HttpResponse fetchAccessToken()`
`59`	`59`	`{`
	`60`	`+ //create a new client for acceess token.`
	`61`	`+ HttpClient AccessTokenClient = new HttpClient(environment);`
`60`	`62`	`AccessTokenRequest request = new AccessTokenRequest(environment, refreshToken);`
`61`		`- var executeTask = this.client.Execute(request);`
	`63`	`+ //make fetch access token call sync to avoid deadlock.`
	`64`	`+ Task<HttpResponse> executeTask = Task.Run<HttpResponse>(async () => await AccessTokenClient.Execute(request));`
`62`	`65`	`return executeTask.Result;`
`63`	`66`	`}`
`64`	`67`	`}`