Skip to content

Commit d7eb2bd

Browse files
AmirAbramsAmirAbrams
committed
[BDAP] Change "Registration days" to "Registration months" in UI
- default account registration to 2 years or 24 months.
1 parent 0c1e5a6 commit d7eb2bd

9 files changed

+10
-11
lines changed

‎src/bdap/bdap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static constexpr unsigned int MAX_BDAP_LINK_MESSAGE = 256;
5454
static constexpr unsigned int MAX_BDAP_SIGNATURE_PROOF = 90; // TODO (bdap): Update to 65 or use MAX_SIGNATURE_LENGTH when you start a new chain.
5555
static constexpr unsigned int MAX_BDAP_LINK_DATA_SIZE = 1592;
5656
static constexpr uint64_t DEFAULT_LINK_EXPIRE_TIME = 1861920000;
57-
static constexpr int32_t DEFAULT_REGISTRATION_MONTHS = 12; // 1 year
57+
static constexpr int32_t DEFAULT_REGISTRATION_MONTHS = 24; // 2 years
5858
static constexpr bool ENFORCE_BDAP_FEES = false; // ********** TODO (BDAP): Update to true after a new testnet.
5959
static const std::string DEFAULT_PUBLIC_DOMAIN = "bdap.io";
6060
static const std::string DEFAULT_PUBLIC_OU = "public";

‎src/bdap/rpcdomainentry.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,11 @@ static UniValue AddDomainEntry(const JSONRPCRequest& request, BDAP::ObjectType b
6969

7070
txDomainEntry.LinkAddress = vchFromString(sxAddr.ToString());
7171

72-
int32_t nMonths = DEFAULT_REGISTRATION_MONTHS; // default to 2 years.
72+
int32_t nMonths = DEFAULT_REGISTRATION_MONTHS; // default to 2 years.
7373
if (request.params.size() >= 3) {
7474
if (!ParseInt32(request.params[2].get_str(), &nMonths))
7575
throw std::runtime_error("BDAP_ADD_PUBLIC_ENTRY_RPC_ERROR: ERRCODE: 3505 - " + _("Error converting registration days to int"));
7676
}
77-
//txDomainEntry.nExpireTime = AddMonthsToCurrentEpoch((short)nMonths);
7877

7978
CharString data;
8079
txDomainEntry.Serialize(data);
@@ -399,7 +398,7 @@ static UniValue UpdateDomainEntry(const JSONRPCRequest& request, BDAP::ObjectTyp
399398
txUpdatedEntry.CommonName = vchCommonName;
400399
txUpdatedEntry.nObjectType = GetObjectTypeInt(bdapType);
401400

402-
int32_t nMonths = DEFAULT_REGISTRATION_MONTHS; // default to 1 year.
401+
int32_t nMonths = DEFAULT_REGISTRATION_MONTHS; // default to 2 years.
403402
if (request.params.size() >= 3) {
404403
if (!ParseInt32(request.params[2].get_str(), &nMonths))
405404
throw std::runtime_error("BDAP_UPDATE_PUBLIC_ENTRY_RPC_ERROR: ERRCODE: 3702 - " + _("Error converting registration days to int"));

‎src/qt/forms/bdapadduserdialog.ui

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
<item row="2" column="0">
3838
<widget class="QLabel" name="labelRegistrationDays">
3939
<property name="text">
40-
<string>Registration days:</string>
40+
<string>Registration months:</string>
4141
</property>
4242
</widget>
4343
</item>

‎src/qt/locale/dynamic_de.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5478,7 +5478,7 @@ zum Beispiel: alertnotify=echo %%s | mail -s &quot;Dynamic Alarm&quot; admin@foo
54785478
<translation>Needs Translating</translation>
54795479
</message>
54805480
<message>
5481-
<source>Registration days:</source>
5481+
<source>Registration months:</source>
54825482
<translation>Needs Translating</translation>
54835483
</message>
54845484
<message>

‎src/qt/locale/dynamic_es.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5466,7 +5466,7 @@ por ejemplo: alertnotify=echo %%s | mail -s &quot;Alerta Dynamic&quot; admin@foo
54665466
<translation>Needs Translating</translation>
54675467
</message>
54685468
<message>
5469-
<source>Registration days:</source>
5469+
<source>Registration months:</source>
54705470
<translation>Needs Translating</translation>
54715471
</message>
54725472
<message>

‎src/qt/locale/dynamic_ko.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5417,7 +5417,7 @@ rpcpassword=%s
54175417
<translation>Needs Translating</translation>
54185418
</message>
54195419
<message>
5420-
<source>Registration days:</source>
5420+
<source>Registration months:</source>
54215421
<translation>Needs Translating</translation>
54225422
</message>
54235423
<message>

‎src/qt/locale/dynamic_nl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5475,7 +5475,7 @@ Bijvoorbeeld: alertnotify=echo %%s | mail -s &quot;Dynamic Alert&quot; admin@foo
54755475
<translation>Needs Translating</translation>
54765476
</message>
54775477
<message>
5478-
<source>Registration days:</source>
5478+
<source>Registration months:</source>
54795479
<translation>Needs Translating</translation>
54805480
</message>
54815481
<message>

‎src/qt/locale/dynamic_pl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5487,7 +5487,7 @@ Na przykład: alertnotify=echo %%s | mail -s &quot;Dynamic Alert&quot; admin@foo
54875487
<translation>Needs Translating</translation>
54885488
</message>
54895489
<message>
5490-
<source>Registration days:</source>
5490+
<source>Registration months:</source>
54915491
<translation>Needs Translating</translation>
54925492
</message>
54935493
<message>

‎src/qt/locale/dynamic_ru.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5464,7 +5464,7 @@ rpcpassword =%s
54645464
<translation>Needs Translating</translation>
54655465
</message>
54665466
<message>
5467-
<source>Registration days:</source>
5467+
<source>Registration months:</source>
54685468
<translation>Needs Translating</translation>
54695469
</message>
54705470
<message>

0 commit comments

Comments
 (0)