ESDK-3843: Added error on attempt set SO_REUSEPORT option under unsupported old Linux.

ViktorYelizarov · ViktorYelizarov · commit 582e7e4d0a94 · 2020-06-02T19:04:48.000+03:00
diff --git a/Cpp-C/Eta/Impl/Transport/ripcutils.c b/Cpp-C/Eta/Impl/Transport/ripcutils.c
@@ -581,10 +581,14 @@ int ipcSockOpts(RsslSocket fd, ripcSocketOption *option)
 #if defined(Linux)
 		case RIPC_SOPT_REUSEPORT:
 		{
+#if defined(SO_REUSEPORT)
 			int reuseFlag = (option->options.turn_on ? 1 : 0);
 			if (setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, (char *)&reuseFlag,
 				(int)sizeof(reuseFlag)) < 0)
 				ret = -1;
+#else
+			ret = -1;
+#endif
 			break;
 		}
 #endif
@@ -1102,10 +1106,17 @@ RsslInt32 ipcSrvrBind(rsslServerImpl *srvr, RsslError *error)
 		sockopts.options.turn_on = 1;
 		if (ipcSockOpts(sock_fd, &sockopts) < 0)
 		{
+#if defined(SO_REUSEPORT)
 			_rsslSetError(error, NULL, RSSL_RET_FAILURE, errno);
 			snprintf(error->text, MAX_RSSL_ERROR_TEXT,
 				"<%s:%d> Error: 1002 Could not to set SO_REUSEPORT on socket. System errno: (%d)\n",
 				__FILE__, __LINE__, errno);
+#else
+			_rsslSetError(error, NULL, RSSL_RET_FAILURE, 0);
+			snprintf(error->text, MAX_RSSL_ERROR_TEXT,
+				"<%s:%d> Error: 1002 Could not to set SO_REUSEPORT on socket. Linux PC does not support SO_REUSEPORT. GCC version: %d.%d.%d\n",
+				__FILE__, __LINE__, __GNUC__, __GNUC_MINOR__, __GNUC_PATCHLEVEL__);
+#endif
 
 			sock_close(sock_fd);
 			return -1;
diff --git a/Cpp-C/Eta/TestTools/UnitTests/rsslTransportUnitTest/rsslTransportUnitTest.cpp b/Cpp-C/Eta/TestTools/UnitTests/rsslTransportUnitTest/rsslTransportUnitTest.cpp
@@ -2883,6 +2883,7 @@ class BindSharedServerSocketOpt : public ::testing::Test {
 };
 
 /* Testing setup of the socket options for server call Bind */
+#if defined(_WIN32) || defined(SO_REUSEPORT)
 TEST_F(BindSharedServerSocketOpt, ServerSharedSocketShouldBeOffWhenDefaultInitValues)
 {
 	// Tests default init-values
@@ -2956,6 +2957,65 @@ TEST_F(BindSharedServerSocketOpt, ServerSharedSocketShouldBeOnWhenSetTrue)
 #endif
 }
 
+#else  // Linux && !defined(SO_REUSEPORT)  // LUP - Linux Unsopported SO_REUSEPORT
+
+TEST_F(BindSharedServerSocketOpt, ServerSharedSocketShouldBeOffWhenDefaultInitValuesLUP)
+{
+	// Tests default init-values
+	RsslBindOptions bindOpts = RSSL_INIT_BIND_OPTS;
+
+	runRsslBind(bindOpts);
+
+	// Tests the socket options: the server socket does not permit sharing
+	testSocketOpt(SO_REUSEADDR, true, "SO_REUSEADDR");
+}
+
+TEST_F(BindSharedServerSocketOpt, ServerSharedSocketShouldBeOffWhenClearBindOptsLUP)
+{
+	// Tests rsslClearBindOpts
+	RsslBindOptions bindOpts;
+	rsslClearBindOpts(&bindOpts);
+
+	runRsslBind(bindOpts);
+
+	// Tests the socket options: the server socket does not permit sharing
+	testSocketOpt(SO_REUSEADDR, true, "SO_REUSEADDR");
+}
+
+TEST_F(BindSharedServerSocketOpt, ServerSharedSocketShouldBeOffWhenSetFalseLUP)
+{
+	// Tests serverSharedSocket off
+	RsslBindOptions bindOpts;
+	rsslClearBindOpts(&bindOpts);
+	bindOpts.serverSharedSocket = RSSL_FALSE;
+
+	runRsslBind(bindOpts);
+
+	// Tests the socket options: the server socket does not permit sharing
+	testSocketOpt(SO_REUSEADDR, true, "SO_REUSEADDR");
+}
+
+TEST_F(BindSharedServerSocketOpt, ServerSharedSocketShouldBeErrorOnRsslBindLUP)
+{
+	// Tests serverSharedSocket on
+	RsslBindOptions bindOpts;
+	RsslError err;
+	rsslClearBindOpts(&bindOpts);
+	bindOpts.serverSharedSocket = RSSL_TRUE;
+
+	bindOpts.serviceName = (char*)"15000";
+	bindOpts.protocolType = TEST_PROTOCOL_TYPE;  /* These tests are just sending a pre-set string across the wire, so protocol type should not be RWF */
+
+	// Tests rsslBind returns NULL because SO_REUSEPORT option is unsupported
+	pServer = rsslBind(&bindOpts, &err);
+
+	ASSERT_EQ(pServer, (RsslServer*)NULL) << "rsslBind should return NULL when required set unsupported option SO_REUSEPORT";
+	ASSERT_EQ(err.rsslErrorId, RSSL_RET_FAILURE) << "Error ccode should set to General Failure";
+	ASSERT_EQ(err.sysError, 0) << "SysError should be equal to 0";
+}
+
+#endif
+
 
 int main(int argc, char* argv[])
 {
