add types for mutations (codesandbox#3619)

christianalfoni · web-flow · commit 32f1c10dbf03 · 2020-03-05T13:22:12.000+01:00
diff --git a/packages/app/src/app/overmind/effects/fakeGql/comments/mutations.ts b/packages/app/src/app/overmind/effects/fakeGql/comments/mutations.ts
@@ -1,13 +1,27 @@
 import gql from 'graphql-tag';
 import { Query } from 'overmind-graphql';
+import {
+  AddCommentResponse,
+  AddCommentVariables,
+  DeleteCommentVariables,
+  DeleteCommentResponse,
+  UpdateCommentVariables,
+  UpdateCommentResponse,
+} from './types';
 
-export const addComment: Query<any, any> = gql`
+export const addComment: Query<AddCommentResponse, AddCommentVariables> = gql`
   mutation AddComment(
     $sandboxId: String!
     $comment: String!
     $username: String!
+    $metadata: String
   ) {
-    addComment(sandboxId: $sandboxId, comment: $comment, username: $username) {
+    addComment(
+      sandboxId: $sandboxId
+      comment: $comment
+      username: $username
+      metadata: $metadata
+    ) {
       id
       isResolved
       originalMessage {
@@ -22,25 +36,37 @@ export const addComment: Query<any, any> = gql`
       replies {
         id
       }
+      metadata
       insertedAt
       updatedAt
     }
   }
 `;
 
-export const deleteComment: Query<any, any> = gql`
+export const deleteComment: Query<
+  DeleteCommentResponse,
+  DeleteCommentVariables
+> = gql`
   mutation DeleteComment($id: String!) {
     deleteComment(id: $id) {
       id
     }
   }
 `;
 
-export const updateComment: Query<any, any> = gql`
-  mutation UpdateComment($id: String!, $comment: String, $isResolved: Boolean) {
+export const updateComment: Query<
+  UpdateCommentResponse,
+  UpdateCommentVariables
+> = gql`
+  mutation UpdateComment(
+    $id: String!
+    $comment: String
+    $isResolved: Boolean
+    $metadata: String
+  ) {
     updateComment(
       id: $id
-      data: { comment: $comment, isResolved: $isResolved }
+      data: { comment: $comment, isResolved: $isResolved, metadata: $metadata }
     ) {
       id
       isResolved
diff --git a/packages/app/src/app/overmind/effects/fakeGql/comments/queries.ts b/packages/app/src/app/overmind/effects/fakeGql/comments/queries.ts
@@ -32,6 +32,7 @@ export const allComments: Query<CommentsResponse, CommentsVariables> = gql`
       }
       insertedAt
       updatedAt
+      metadata
     }
   }
 `;
@@ -59,6 +60,7 @@ export const comment: Query<CommentResponse, CommentVariables> = gql`
       }
       insertedAt
       updatedAt
+      metadata
     }
   }
 `;
diff --git a/packages/app/src/app/overmind/effects/fakeGql/comments/types.ts b/packages/app/src/app/overmind/effects/fakeGql/comments/types.ts
@@ -17,6 +17,7 @@ export type Comment = {
   replies: Message[];
   insertedAt: string;
   updatedAt?: string;
+  metadata?: string;
 };
 
 export type CommentsVariables = {
@@ -32,6 +33,7 @@ export type CommentsResponse = {
       originalMessage: Message;
       insertedAt: string;
       updatedAt: string;
+      metadata: string;
     }
   ];
 };
@@ -40,12 +42,46 @@ export type AddCommentVariables = {
   sandboxId: string;
   comment: string;
   username: string;
+  metadata?: string;
 };
 
 export type AddCommentResponse = {
   addComment: {
     id: string;
+    isResolved: boolean;
+    replies: Pick<Message, 'id'>[];
     originalMessage: Message;
+    insertedAt: string;
+    updatedAt: string;
+    metadata: string;
+  };
+};
+
+export type DeleteCommentVariables = {
+  id: string;
+};
+
+export type DeleteCommentResponse = {
+  deleteComment: {
+    id: string;
+  };
+};
+
+export type UpdateCommentVariables = {
+  id: string;
+  comment?: string;
+  isResolved?: boolean;
+  metadata?: string;
+};
+
+export type UpdateCommentResponse = {
+  updateComment: {
+    id: string;
+    isResolved: string;
+    originalMessage: {
+      id: string;
+      content: string;
+    };
   };
 };
 
@@ -65,5 +101,6 @@ export type CommentResponse = {
     replies: Message[];
     insertedAt: string;
     updatedAt: string;
+    metadata: string;
   };
 };

Original file line number	Diff line number	Diff line change
@@ -32,6 +32,7 @@ export const allComments: Query<CommentsResponse, CommentsVariables> = gql`
`32`	`32`	`}`
`33`	`33`	`insertedAt`
`34`	`34`	`updatedAt`
	`35`	`+ metadata`
`35`	`36`	`}`
`36`	`37`	`}`
`37`	`38`	`;
@@ -59,6 +60,7 @@ export const comment: Query<CommentResponse, CommentVariables> = gql`
`59`	`60`	`}`
`60`	`61`	`insertedAt`
`61`	`62`	`updatedAt`
	`63`	`+ metadata`
`62`	`64`	`}`
`63`	`65`	`}`
`64`	`66`	`;