Skip to content

Commit c77caae

Browse files
authored
refactor DirectoryEntry (codesandbox#3199)
1 parent 65aac8c commit c77caae

File tree

3 files changed

+15
-22
lines changed

3 files changed

+15
-22
lines changed

packages/app/src/app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/DirectoryChildren/index.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,10 @@ const DirectoryChildren: React.FC<IDirectoryChildrenProps> = ({
3636
renameValidator,
3737
}) => {
3838
const {
39-
state: {
40-
editor: { currentSandbox, mainModule, currentModuleShortid },
41-
},
39+
state: { isLoggedIn, editor: editorState },
4240
actions: { files, editor },
4341
} = useOvermind();
42+
const { currentSandbox, mainModule, currentModuleShortid } = editorState;
4443

4544
const {
4645
id: sandboxId,
@@ -65,6 +64,7 @@ const DirectoryChildren: React.FC<IDirectoryChildrenProps> = ({
6564
siblings={[...directories, ...modules]}
6665
depth={depth + 1}
6766
signals={{ files, editor }}
67+
store={{ editor: editorState, isLoggedIn }}
6868
id={dir.id}
6969
shortid={dir.shortid}
7070
title={dir.title}

packages/app/src/app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/index.js

+5-11
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { inject, observer } from 'app/componentConnectors';
21
import { reaction } from 'mobx';
32
import React from 'react';
43
import { DropTarget } from 'react-dnd';
@@ -400,13 +399,8 @@ function collectTarget(connectMonitor, monitor) {
400399
};
401400
}
402401

403-
export default inject(
404-
'signals',
405-
'store'
406-
)(
407-
DropTarget(
408-
['ENTRY', NativeTypes.FILE],
409-
entryTarget,
410-
collectTarget
411-
)(observer(DirectoryEntry))
412-
);
402+
export default DropTarget(
403+
['ENTRY', NativeTypes.FILE],
404+
entryTarget,
405+
collectTarget
406+
)(DirectoryEntry);

packages/app/src/app/pages/Sandbox/Editor/Workspace/Files/index.tsx

+7-8
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,12 @@ interface IFilesProps {
1111

1212
export const Files: React.FC<IFilesProps> = ({ setEditActions }) => {
1313
const {
14-
state: {
15-
editor: { currentSandbox: sandbox },
16-
isLoggedIn,
17-
},
18-
actions: {
19-
editor: { createZipClicked },
20-
},
14+
state: { editor: editorState, isLoggedIn },
15+
actions: { editor, files },
2116
} = useOvermind();
2217

18+
const { currentSandbox: sandbox } = editorState;
19+
2320
const _getModulePath = moduleId => {
2421
try {
2522
return getModulePath(sandbox.modules, sandbox.directories, moduleId);
@@ -33,6 +30,8 @@ export const Files: React.FC<IFilesProps> = ({ setEditActions }) => {
3330
root
3431
getModulePath={_getModulePath}
3532
title={sandbox.title || 'Project'}
33+
signals={{ files, editor }}
34+
store={{ editor: editorState, isLoggedIn }}
3635
initializeProperties={({
3736
onCreateModuleClick,
3837
onCreateDirectoryClick,
@@ -46,7 +45,7 @@ export const Files: React.FC<IFilesProps> = ({ setEditActions }) => {
4645
forceShow={window.__isTouch}
4746
onCreateFile={onCreateModuleClick}
4847
onCreateDirectory={onCreateDirectoryClick}
49-
onDownload={createZipClicked}
48+
onDownload={editor.createZipClicked}
5049
onUploadFile={
5150
isLoggedIn && sandbox.privacy === 0
5251
? onUploadFileClick

0 commit comments

Comments
 (0)