fix: do not ignore electron exit signals in cli.js wrapper (electron#22878)

andersk · web-flow · commit 1746ae8c35c3 · 2020-04-13T15:49:01.000+09:00
When the electron child process exits with a signal, the close event
handler receives code null and the cli wrapper would silently exit
successfully.  Fix it to log a message and exit with a nonzero code in
this case.

Signed-off-by: Anders Kaseorg &lt;andersk@mit.edu&gt;
diff --git a/npm/cli.js b/npm/cli.js
@@ -5,7 +5,11 @@ var electron = require('./')
 var proc = require('child_process')
 
 var child = proc.spawn(electron, process.argv.slice(2), { stdio: 'inherit', windowsHide: false })
-child.on('close', function (code) {
+child.on('close', function (code, signal) {
+  if (code === null) {
+    console.error(electron, 'exited with signal', signal)
+    process.exit(1)
+  }
   process.exit(code)
 })
 
