chore: use node_bindings loop for clarity (electron#24416)

trop[bot] · codebytere · web-flow · commit 48cd3eecede5 · 2020-07-03T18:47:37.000-07:00
Co-authored-by: Shelley Vohr &lt;shelley.vohr@gmail.com&gt;
diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc
@@ -251,7 +251,7 @@ ElectronBrowserMainParts::ElectronBrowserMainParts(
       browser_(new Browser),
       node_bindings_(
           NodeBindings::Create(NodeBindings::BrowserEnvironment::BROWSER)),
-      electron_bindings_(new ElectronBindings(uv_default_loop())) {
+      electron_bindings_(new ElectronBindings(node_bindings_->uv_loop())) {
   DCHECK(!self_) << "Cannot have two ElectronBrowserMainParts";
   self_ = this;
 }
diff --git a/shell/renderer/electron_renderer_client.cc b/shell/renderer/electron_renderer_client.cc
@@ -37,7 +37,7 @@ bool IsDevToolsExtension(content::RenderFrame* render_frame) {
 ElectronRendererClient::ElectronRendererClient()
     : node_bindings_(
           NodeBindings::Create(NodeBindings::BrowserEnvironment::RENDERER)),
-      electron_bindings_(new ElectronBindings(uv_default_loop())) {}
+      electron_bindings_(new ElectronBindings(node_bindings_->uv_loop())) {}
 
 ElectronRendererClient::~ElectronRendererClient() {
   asar::ClearArchives();

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ ElectronBrowserMainParts::ElectronBrowserMainParts(`
`251`	`251`	`browser_(new Browser),`
`252`	`252`	`node_bindings_(`
`253`	`253`	`NodeBindings::Create(NodeBindings::BrowserEnvironment::BROWSER)),`
`254`		`- electron_bindings_(new ElectronBindings(uv_default_loop())) {`
	`254`	`+ electron_bindings_(new ElectronBindings(node_bindings_->uv_loop())) {`
`255`	`255`	`DCHECK(!self_) << "Cannot have two ElectronBrowserMainParts";`
`256`	`256`	`self_ = this;`
`257`	`257`	`}`