Skip to content

Commit 99079c3

Browse files
build: fix build with context snapshot disabled (electron#24433)
1 parent 1f23807 commit 99079c3

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

BUILD.gn

+7-2
Original file line numberDiff line numberDiff line change
@@ -1102,7 +1102,9 @@ if (is_mac) {
11021102
data += [ "$root_out_dir/resources/default_app.asar" ]
11031103
}
11041104

1105-
public_deps = [ "//tools/v8_context_snapshot:v8_context_snapshot" ]
1105+
if (use_v8_context_snapshot) {
1106+
public_deps = [ "//tools/v8_context_snapshot:v8_context_snapshot" ]
1107+
}
11061108

11071109
if (is_win) {
11081110
sources += [
@@ -1307,10 +1309,13 @@ dist_zip("electron_chromedriver_zip") {
13071309

13081310
mksnapshot_deps = [
13091311
":licenses",
1310-
"//tools/v8_context_snapshot:v8_context_snapshot_generator($v8_snapshot_toolchain)",
13111312
"//v8:mksnapshot($v8_snapshot_toolchain)",
13121313
]
13131314

1315+
if (use_v8_context_snapshot) {
1316+
mksnapshot_deps += [ "//tools/v8_context_snapshot:v8_context_snapshot_generator($v8_snapshot_toolchain)" ]
1317+
}
1318+
13141319
group("electron_mksnapshot") {
13151320
public_deps = mksnapshot_deps
13161321
}

0 commit comments

Comments
 (0)