blockchain: instantiating Block with empty/undefined data

evertonfraga · evertonfraga · commit 0a66d2c39db2 · 2020-04-21T07:05:26.000-04:00
diff --git a/packages/blockchain/src/index.ts b/packages/blockchain/src/index.ts
@@ -312,7 +312,7 @@ export default class Blockchain implements BlockchainInterface {
    * @hidden
    */
   _setCanonicalGenesisBlock(cb: any): void {
-    const genesisBlock = new Block(Buffer.from([]), { common: this._common })
+    const genesisBlock = new Block(undefined, { common: this._common })
     genesisBlock.setGenesisParams()
     this._putBlockOrHeader(genesisBlock, cb, true)
   }
diff --git a/packages/blockchain/test/index.ts b/packages/blockchain/test/index.ts
@@ -875,9 +875,9 @@ test('blockchain test', t => {
     const common = new Common('mainnet')
     const blockchain = new Blockchain({ common: common, validateBlocks: true, validatePow: false })
     const blocks = [
-      new Block(null, { common: common }),
-      new Block(null, { chain: 'mainnet' }),
-      new Block(null, { chain: 'ropsten' }),
+      new Block(undefined, { common: common }),
+      new Block(undefined, { chain: 'mainnet' }),
+      new Block(undefined, { chain: 'ropsten' }),
     ]
 
     blocks[0].setGenesisParams()

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ export default class Blockchain implements BlockchainInterface {`
`312`	`312`	`* @hidden`
`313`	`313`	`*/`
`314`	`314`	`_setCanonicalGenesisBlock(cb: any): void {`
`315`		`- const genesisBlock = new Block(Buffer.from([]), { common: this._common })`
	`315`	`+ const genesisBlock = new Block(undefined, { common: this._common })`
`316`	`316`	`genesisBlock.setGenesisParams()`
`317`	`317`	`this._putBlockOrHeader(genesisBlock, cb, true)`
`318`	`318`	`}`