set web device name to Chrome (flutter#34856)

jonahwilliams · web-flow · commit 19d7925f1f7d · 2019-06-21T14:26:25.000-07:00
diff --git a/packages/flutter_tools/lib/src/web/web_device.dart b/packages/flutter_tools/lib/src/web/web_device.dart
@@ -27,9 +27,9 @@ class WebApplicationPackage extends ApplicationPackage {
   Directory get webSourcePath => flutterProject.directory.childDirectory('web');
 }
 
-class WebDevice extends Device {
-  WebDevice() : super(
-      'web',
+class ChromeDevice extends Device {
+  ChromeDevice() : super(
+      'chrome',
       category: Category.web,
       platformType: PlatformType.web,
       ephemeral: false,
@@ -74,7 +74,7 @@ class WebDevice extends Device {
   bool isSupported() => flutterWebEnabled && canFindChrome();
 
   @override
-  String get name => 'web';
+  String get name => 'Chrome';
 
   @override
   DevicePortForwarder get portForwarder => const NoOpDevicePortForwarder();
@@ -143,9 +143,9 @@ class WebDevice extends Device {
 }
 
 class WebDevices extends PollingDeviceDiscovery {
-  WebDevices() : super('web');
+  WebDevices() : super('chrome');
 
-  final WebDevice _webDevice = WebDevice();
+  final ChromeDevice _webDevice = ChromeDevice();
 
   @override
   bool get canListAnything => flutterWebEnabled;
diff --git a/packages/flutter_tools/test/web/devices_test.dart b/packages/flutter_tools/test/web/devices_test.dart
@@ -13,7 +13,7 @@ import '../src/common.dart';
 import '../src/context.dart';
 
 void main() {
-  group(WebDevice, () {
+  group(ChromeDevice, () {
    MockChromeLauncher mockChromeLauncher;
    MockPlatform mockPlatform;
    MockProcessManager mockProcessManager;
@@ -26,13 +26,27 @@ void main() {
         return null;
       });
     });
+
+    test('Defaults', () async {
+      final ChromeDevice device = ChromeDevice();
+
+      expect(device.name, 'Chrome');
+      expect(device.id, 'chrome');
+      expect(device.supportsHotReload, true);
+      expect(device.supportsHotRestart, true);
+      expect(device.supportsStartPaused, true);
+      expect(device.supportsFlutterExit, true);
+      expect(device.supportsScreenshot, false);
+      expect(await device.isLocalEmulator, false);
+    });
+
     testUsingContext('Invokes version command on non-Windows platforms', () async{
       when(mockPlatform.isWindows).thenReturn(false);
       when(mockProcessManager.canRun('chrome.foo')).thenReturn(true);
       when(mockProcessManager.run(<String>['chrome.foo', '--version'])).thenAnswer((Invocation invocation) async {
         return MockProcessResult(0, 'ABC');
       });
-      final WebDevice webDevice = WebDevice();
+      final ChromeDevice webDevice = ChromeDevice();
 
       expect(webDevice.isSupported(), true);
       expect(await webDevice.sdkNameAndVersion, 'ABC');
@@ -53,7 +67,7 @@ void main() {
       ])).thenAnswer((Invocation invocation) async {
         return MockProcessResult(0, r'HKEY_CURRENT_USER\Software\Google\Chrome\BLBeacon\ version REG_SZ 74.0.0 A');
       });
-      final WebDevice webDevice = WebDevice();
+      final ChromeDevice webDevice = ChromeDevice();
 
       expect(webDevice.isSupported(), true);
       expect(await webDevice.sdkNameAndVersion, 'Google Chrome 74.0.0');
