Skip to content

Commit 1b3b4ec

Browse files
author
Nurhan Turgut
authored
skip font loading tests for safari (flutter#18232)
1 parent 576f0e1 commit 1b3b4ec

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

lib/web_ui/test/text/font_loading_test.dart

+12-4
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@ Future<void> main() async {
2626
ui.loadFontFromList(Uint8List(0), fontFamily: 'test-font'),
2727
throwsA(TypeMatcher<Exception>()));
2828
},
29+
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
2930
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
30-
skip: browserEngine == BrowserEngine.edge);
31+
skip: (browserEngine == BrowserEngine.edge ||
32+
browserEngine == BrowserEngine.webkit));
3133

3234
test('loads Blehm font from buffer', () async {
3335
expect(_containsFontFamily('Blehm'), false);
@@ -40,8 +42,10 @@ Future<void> main() async {
4042

4143
expect(_containsFontFamily('Blehm'), true);
4244
},
45+
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
4346
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
44-
skip: browserEngine == BrowserEngine.edge);
47+
skip: (browserEngine == BrowserEngine.edge ||
48+
browserEngine == BrowserEngine.webkit));
4549

4650
test('loading font should clear measurement caches', () async {
4751
final ui.ParagraphStyle style = ui.ParagraphStyle();
@@ -66,8 +70,10 @@ Future<void> main() async {
6670
expect(_containsFontFamily('Blehm'), true);
6771
expect(TextMeasurementService.rulerManager.rulers.length, 0);
6872
},
73+
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
6974
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
70-
skip: browserEngine == BrowserEngine.edge);
75+
skip: (browserEngine == BrowserEngine.edge ||
76+
browserEngine == BrowserEngine.webkit));
7177

7278
test('loading font should send font change message', () async {
7379
final ui.PlatformMessageCallback oldHandler = ui.window.onPlatformMessage;
@@ -93,8 +99,10 @@ Future<void> main() async {
9399
expect(actualName, 'flutter/system');
94100
expect(message, '{"type":"fontsChange"}');
95101
},
102+
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
96103
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
97-
skip: browserEngine == BrowserEngine.edge);
104+
skip: (browserEngine == BrowserEngine.edge ||
105+
browserEngine == BrowserEngine.webkit));
98106
});
99107
}
100108

0 commit comments

Comments
 (0)