Avoid overwriting task result for non-leak checkers (flutter#29989)

dnfield · web-flow · commit 820b0e029eef · 2019-03-26T11:40:05.000-07:00
diff --git a/dev/devicelab/lib/framework/framework.dart b/dev/devicelab/lib/framework/framework.dart
@@ -102,8 +102,6 @@ class _TaskRunner {
           // TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved.
           if (result is TaskResultCheckProcesses) {
             result = TaskResult.failure('This test leaked dart processes');
-          } else {
-            result = TaskResult.success(null);
           }
           final bool killed = await killProcess(info.pid);
           if (!killed) {

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,6 @@ class _TaskRunner {`
`102`	`102`	`// TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved.`
`103`	`103`	`if (result is TaskResultCheckProcesses) {`
`104`	`104`	`result = TaskResult.failure('This test leaked dart processes');`
`105`		`- } else {`
`106`		`- result = TaskResult.success(null);`
`107`	`105`	`}`
`108`	`106`	`final bool killed = await killProcess(info.pid);`
`109`	`107`	`if (!killed) {`