Enable shouldCapTextScaleForTitle by default (flutter#60684)

perclasson · web-flow · commit b35f2cd4caaf · 2020-07-01T10:53:01.000-07:00
diff --git a/packages/flutter/lib/src/material/app_bar_theme.dart b/packages/flutter/lib/src/material/app_bar_theme.dart
@@ -46,7 +46,7 @@ class AppBarTheme with Diagnosticable {
       'This feature was deprecated after v1.19.0.'
     )
     // ignore: deprecated_member_use_from_same_package
-    this.shouldCapTextScaleForTitle = false,
+    this.shouldCapTextScaleForTitle = true,
   });
 
   /// Default value for [AppBar.brightness].
diff --git a/packages/flutter/test/material/app_bar_test.dart b/packages/flutter/test/material/app_bar_test.dart
@@ -1835,21 +1835,12 @@ void main() {
       return MaterialApp(
         home: Builder(
           builder: (BuildContext context) {
-            final ThemeData themeData = Theme.of(context);
-            return Theme(
-              data: themeData.copyWith(
-                appBarTheme: themeData.appBarTheme.copyWith(
-                  // ignore: deprecated_member_use_from_same_package
-                  shouldCapTextScaleForTitle: true,
-                ),
-              ),
-              child: MediaQuery(
-                data: MediaQuery.of(context).copyWith(textScaleFactor: textScaleFactor),
-                child: Scaffold(
-                  appBar: AppBar(
-                    centerTitle: false,
-                    title: const Text('Jumbo', style: TextStyle(fontSize: 18)),
-                  ),
+            return MediaQuery(
+              data: MediaQuery.of(context).copyWith(textScaleFactor: textScaleFactor),
+              child: Scaffold(
+                appBar: AppBar(
+                  centerTitle: false,
+                  title: const Text('Jumbo', style: TextStyle(fontSize: 18)),
                 ),
               ),
             );
@@ -1884,18 +1875,18 @@ void main() {
           builder: (BuildContext context) {
             return Directionality(
               textDirection: textDirection,
-              child: MediaQuery(
-                data: MediaQuery.of(context).copyWith(textScaleFactor: textScaleFactor),
-                child: Builder(
-                  builder: (BuildContext context) {
-                    return Scaffold(
-                      appBar: AppBar(
-                        centerTitle: centerTitle,
-                        title: const Text('Jumbo'),
+              child: Builder(
+                builder: (BuildContext context) {
+                  return Scaffold(
+                    appBar: AppBar(
+                      centerTitle: centerTitle,
+                      title: MediaQuery(
+                        data: MediaQuery.of(context).copyWith(textScaleFactor: textScaleFactor),
+                        child: const Text('Jumbo'),
                       ),
-                    );
-                  },
-                ),
+                    ),
+                  );
+                },
               ),
             );
           },

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class AppBarTheme with Diagnosticable {`
`46`	`46`	`'This feature was deprecated after v1.19.0.'`
`47`	`47`	`)`
`48`	`48`	`// ignore: deprecated_member_use_from_same_package`
`49`		`- this.shouldCapTextScaleForTitle = false,`
	`49`	`+ this.shouldCapTextScaleForTitle = true,`
`50`	`50`	`});`
`51`	`51`
`52`	`52`	`/// Default value for [AppBar.brightness].`