move hack flag to common (flutter#34754)

jonahwilliams · web-flow · commit d7e53d4816c3 · 2019-06-19T16:29:11.000-07:00
diff --git a/packages/flutter_tools/lib/src/base/common.dart b/packages/flutter_tools/lib/src/base/common.dart
@@ -5,6 +5,10 @@
 import 'file_system.dart';
 import 'platform.dart';
 
+/// Whether the tool started from the daemon, as opposed to the command line.
+// TODO(jonahwilliams): remove once IDE updates have rolled.
+bool isRunningFromDaemon = false;
+
 /// Return the absolute path of the user's home directory
 String get homeDirPath {
   String path = platform.isWindows
diff --git a/packages/flutter_tools/lib/src/commands/daemon.dart b/packages/flutter_tools/lib/src/commands/daemon.dart
@@ -28,10 +28,6 @@ import '../vmservice.dart';
 
 const String protocolVersion = '0.5.2';
 
-/// Whether the tool started from the daemon, as opposed to the command line.
-bool get isRunningFromDaemon => _isRunningFromDaemon;
-bool _isRunningFromDaemon = false;
-
 /// A server process command. This command will start up a long-lived server.
 /// It reads JSON-RPC based commands from stdin, executes them, and returns
 /// JSON-RPC based responses and events to stdout.
@@ -53,7 +49,7 @@ class DaemonCommand extends FlutterCommand {
   @override
   Future<FlutterCommandResult> runCommand() async {
     printStatus('Starting device daemon...');
-    _isRunningFromDaemon = true;
+    isRunningFromDaemon = true;
 
     final NotifyingLogger notifyingLogger = NotifyingLogger();
 
diff --git a/packages/flutter_tools/lib/src/desktop.dart b/packages/flutter_tools/lib/src/desktop.dart
@@ -6,10 +6,10 @@ import 'dart:async';
 
 import 'package:meta/meta.dart';
 
+import 'base/common.dart';
 import 'base/io.dart';
 import 'base/platform.dart';
 import 'base/process_manager.dart';
-import 'commands/daemon.dart' show isRunningFromDaemon;
 import 'convert.dart';
 import 'device.dart';
 import 'version.dart';
diff --git a/packages/flutter_tools/lib/src/web/workflow.dart b/packages/flutter_tools/lib/src/web/workflow.dart
@@ -4,10 +4,10 @@
 
 import 'package:meta/meta.dart';
 
+import '../base/common.dart';
 import '../base/context.dart';
 import '../base/platform.dart';
 import '../base/process_manager.dart';
-import '../commands/daemon.dart' show isRunningFromDaemon;
 import '../doctor.dart';
 import '../version.dart';
 import 'chrome.dart';
