Skip to content

Commit 0c83dbc

Browse files
committed
Make Symbol work in IE10-11 (kinda xD)
1 parent fc7c397 commit 0c83dbc

File tree

3 files changed

+29
-7
lines changed

3 files changed

+29
-7
lines changed

packages/browser/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
"rollup": "^1.10.1",
4444
"rollup-plugin-commonjs": "^9.3.4",
4545
"rollup-plugin-license": "^0.8.1",
46+
"rollup-plugin-modify": "^3.0.0",
4647
"rollup-plugin-node-resolve": "^4.2.3",
4748
"rollup-plugin-terser": "^4.0.4",
4849
"rollup-plugin-typescript2": "^0.21.0",

packages/browser/rollup.config.js

+6
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import typescript from 'rollup-plugin-typescript2';
33
import license from 'rollup-plugin-license';
44
import resolve from 'rollup-plugin-node-resolve';
55
import commonjs from 'rollup-plugin-commonjs';
6+
import modify from 'rollup-plugin-modify';
67

78
const commitHash = require('child_process')
89
.execSync('git rev-parse --short HEAD', { encoding: 'utf-8' })
@@ -46,6 +47,11 @@ const plugins = [
4647
mainFields: ['module'],
4748
}),
4849
commonjs(),
50+
modify({
51+
// It's very difficult to use Symbol without polyfilling in IE10 and still making TypeScript behave correctly.
52+
// Just remove it and leave this space in there, so that SourceMaps are still correct.
53+
"this[Symbol.toStringTag] = '[object SyncPromise]';": ' ',
54+
}),
4955
];
5056

5157
const bundleConfig = {

yarn.lock

+22-7
Original file line numberDiff line numberDiff line change
@@ -7192,20 +7192,20 @@ magic-string@0.25.1, magic-string@^0.25.1:
71927192
dependencies:
71937193
sourcemap-codec "^1.4.1"
71947194

7195+
magic-string@0.25.2, magic-string@^0.25.2:
7196+
version "0.25.2"
7197+
resolved "https://registry.yarnpkg.com/magic-string/-/magic-string-0.25.2.tgz#139c3a729515ec55e96e69e82a11fe890a293ad9"
7198+
integrity sha512-iLs9mPjh9IuTtRsqqhNGYcZXGei0Nh/A4xirrsqW7c+QhKVFL2vm7U09ru6cHRD22azaP/wMDgI+HCqbETMTtg==
7199+
dependencies:
7200+
sourcemap-codec "^1.4.4"
7201+
71957202
magic-string@^0.19.0:
71967203
version "0.19.1"
71977204
resolved "https://registry.yarnpkg.com/magic-string/-/magic-string-0.19.1.tgz#14d768013caf2ec8fdea16a49af82fc377e75201"
71987205
integrity sha1-FNdoATyvLsj96hakmvgvw3fnUgE=
71997206
dependencies:
72007207
vlq "^0.2.1"
72017208

7202-
magic-string@^0.25.2:
7203-
version "0.25.2"
7204-
resolved "https://registry.yarnpkg.com/magic-string/-/magic-string-0.25.2.tgz#139c3a729515ec55e96e69e82a11fe890a293ad9"
7205-
integrity sha512-iLs9mPjh9IuTtRsqqhNGYcZXGei0Nh/A4xirrsqW7c+QhKVFL2vm7U09ru6cHRD22azaP/wMDgI+HCqbETMTtg==
7206-
dependencies:
7207-
sourcemap-codec "^1.4.4"
7208-
72097209
make-dir@^1.0.0, make-dir@^1.3.0:
72107210
version "1.3.0"
72117211
resolved "https://registry.yarnpkg.com/make-dir/-/make-dir-1.3.0.tgz#79c1033b80515bd6d24ec9933e860ca75ee27f0c"
@@ -8186,6 +8186,13 @@ osenv@0, osenv@^0.1.4, osenv@^0.1.5:
81868186
os-homedir "^1.0.0"
81878187
os-tmpdir "^1.0.0"
81888188

8189+
ospec@3.1.0:
8190+
version "3.1.0"
8191+
resolved "https://registry.yarnpkg.com/ospec/-/ospec-3.1.0.tgz#d36b8e10110f58f63a463df2390a7a73fe9579a8"
8192+
integrity sha512-+nGtjV3vlADp+UGfL51miAh/hB4awPBkQrArhcgG4trAaoA2gKt5bf9w0m9ch9zOr555cHWaCHZEDiBOkNZSxw==
8193+
dependencies:
8194+
glob "^7.1.3"
8195+
81898196
override-require@^1.1.1:
81908197
version "1.1.1"
81918198
resolved "https://registry.yarnpkg.com/override-require/-/override-require-1.1.1.tgz#6ae22fadeb1f850ffb0cf4c20ff7b87e5eb650df"
@@ -9359,6 +9366,14 @@ rollup-plugin-license@^0.8.1:
93599366
mkdirp "0.5.1"
93609367
moment "2.23.0"
93619368

9369+
rollup-plugin-modify@^3.0.0:
9370+
version "3.0.0"
9371+
resolved "https://registry.yarnpkg.com/rollup-plugin-modify/-/rollup-plugin-modify-3.0.0.tgz#5326e11dfec247e8bbdd9507f3da1da1e5c7818b"
9372+
integrity sha512-p/ffs0Y2jz2dEnWjq1oVC7SY37tuS+aP7whoNaQz1EAAOPg+k3vKJo8cMMWx6xpdd0NzhX4y2YF9o/NPu5YR0Q==
9373+
dependencies:
9374+
magic-string "0.25.2"
9375+
ospec "3.1.0"
9376+
93629377
rollup-plugin-node-resolve@^4.2.3:
93639378
version "4.2.3"
93649379
resolved "https://registry.yarnpkg.com/rollup-plugin-node-resolve/-/rollup-plugin-node-resolve-4.2.3.tgz#638a373a54287d19fcc088fdd1c6fd8a58e4d90a"

0 commit comments

Comments
 (0)