fix: Add finish method to the Span interface

kamilogorek · kamilogorek · commit 11e3f8b9e54f · 2019-11-01T11:27:53.000+01:00
diff --git a/packages/hub/test/span.test.ts b/packages/hub/test/span.test.ts
@@ -1,4 +1,4 @@
-import { Span, Hub, Scope, TRACEPARENT_REGEXP } from '../src';
+import { Hub, Scope, Span, TRACEPARENT_REGEXP } from '../src';
 
 describe('Span', () => {
   let hub: Hub;
diff --git a/packages/types/src/span.ts b/packages/types/src/span.ts
@@ -1,5 +1,7 @@
 /** Span holding trace_id, span_id */
 export interface Span {
+  /** Sets the finish timestamp on the current span and sends it if it was a transaction */
+  finish(): string | undefined;
   /** Return a traceparent compatible header string */
   toTraceparent(): string;
   /** Convert the object to JSON for w. spans array info only */

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Span, Hub, Scope, TRACEPARENT_REGEXP } from '../src';`
	`1`	`+import { Hub, Scope, Span, TRACEPARENT_REGEXP } from '../src';`
`2`	`2`
`3`	`3`	`describe('Span', () => {`
`4`	`4`	`let hub: Hub;`