ref: naming

HazAT · kamilogorek · commit 1b9ebd9fa2c3 · 2019-11-01T11:27:39.000+01:00
diff --git a/packages/hub/src/hub.ts b/packages/hub/src/hub.ts
@@ -404,7 +404,7 @@ export class Hub implements HubInterface {
       const span = top.scope.getSpan();
 
       if (span) {
-        return span.makeChild(spanContext);
+        return span.child(spanContext);
       }
     }
 
diff --git a/packages/hub/src/span.ts b/packages/hub/src/span.ts
@@ -116,7 +116,7 @@ export class Span implements SpanInterface, SpanContext {
    * Creates a new `Span` while setting the current `Span.id` as `parentSpanId`.
    * Also the `sampled` decision will be inherited.
    */
-  public makeChild(spanContext?: Pick<SpanContext, Exclude<keyof SpanContext, 'spanId'>>): Span {
+  public child(spanContext?: Pick<SpanContext, Exclude<keyof SpanContext, 'spanId'>>): Span {
     const span = new Span({
       ...spanContext,
       parentSpanId: this._spanId,
diff --git a/packages/hub/test/span.test.ts b/packages/hub/test/span.test.ts
@@ -12,15 +12,15 @@ describe('Span', () => {
   describe('newSpan', () => {
     test('simple', () => {
       const span = new Span({ sampled: true });
-      const span2 = span.makeChild();
+      const span2 = span.child();
       expect((span2 as any)._parentSpanId).toBe((span as any)._spanId);
       expect((span2 as any)._traceId).toBe((span as any)._traceId);
       expect((span2 as any).sampled).toBe((span as any).sampled);
     });
 
     test('gets currentHub', () => {
       const span = new Span({});
-      const span2 = span.makeChild();
+      const span2 = span.child();
       expect((span as any)._hub).toBeInstanceOf(Hub);
       expect((span2 as any)._hub).toBeInstanceOf(Hub);
     });
@@ -74,15 +74,15 @@ describe('Span', () => {
   describe('newSpan', () => {
     test('simple', () => {
       const span = new Span({ sampled: true });
-      const span2 = span.makeChild();
+      const span2 = span.child();
       expect((span2 as any)._parentSpanId).toBe((span as any)._spanId);
       expect((span2 as any)._traceId).toBe((span as any)._traceId);
       expect((span2 as any).sampled).toBe((span as any).sampled);
     });
 
     test('gets currentHub', () => {
       const span = new Span({});
-      const span2 = span.makeChild();
+      const span2 = span.child();
       expect((span as any)._hub).toBeInstanceOf(Hub);
       expect((span2 as any)._hub).toBeInstanceOf(Hub);
     });
@@ -178,7 +178,7 @@ describe('Span', () => {
     test('finish a scope span with transaction + child span', () => {
       const spy = jest.spyOn(hub as any, 'captureEvent') as any;
       const parentSpan = new Span({ transaction: 'test' }, hub);
-      const childSpan = parentSpan.makeChild();
+      const childSpan = parentSpan.child();
       childSpan.finish();
       parentSpan.finish();
       expect(spy).toHaveBeenCalled();

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ export class Hub implements HubInterface {`
`404`	`404`	`const span = top.scope.getSpan();`
`405`	`405`
`406`	`406`	`if (span) {`
`407`		`- return span.makeChild(spanContext);`
	`407`	`+ return span.child(spanContext);`
`408`	`408`	`}`
`409`	`409`	`}`
`410`	`410`