meta: beta.3

HazAT · kamilogorek · commit 4b35daf4383f · 2019-11-01T11:27:26.000+01:00
diff --git a/packages/core/src/api.ts b/packages/core/src/api.ts
@@ -54,7 +54,7 @@ export class API {
   public getRequestHeaders(clientName: string, clientVersion: string): { [key: string]: string } {
     const dsn = this._dsnObject;
     const header = [`Sentry sentry_version=${SENTRY_API_VERSION}`];
-    header.push(`sentry_timestamp=${timestampWithMs()}`);
+    header.push(`sentry_timestamp=${timestampWithMs()}`); // TODO: This can be removed
     header.push(`sentry_client=${clientName}/${clientVersion}`);
     header.push(`sentry_key=${dsn.user}`);
     if (dsn.pass) {
diff --git a/packages/hub/src/hub.ts b/packages/hub/src/hub.ts
@@ -433,6 +433,7 @@ export class Hub implements HubInterface {
     }
 
     if (passedSpan === undefined) {
+      logger.warn('There was no Span on the Scope and none was passed, do nothing.');
       // We will do nothing since nothing was passed and there is no Span on the scope.
       return undefined;
     }
diff --git a/packages/minimal/src/index.ts b/packages/minimal/src/index.ts
@@ -190,5 +190,5 @@ export function startSpan(spanContext?: SpanContext, bindOnScope?: boolean): Spa
  * @param span `Span` instance that was created by {@link startSpan}
  */
 export function finishSpan(span?: Span): string | undefined {
-  return callOnHub<string | undefined>('startSpan', span);
+  return callOnHub<string | undefined>('finishSpan', span);
 }

Original file line number	Diff line number	Diff line change
`@@ -433,6 +433,7 @@ export class Hub implements HubInterface {`
`433`	`433`	`}`
`434`	`434`
`435`	`435`	`if (passedSpan === undefined) {`
	`436`	`+ logger.warn('There was no Span on the Scope and none was passed, do nothing.');`
`436`	`437`	`// We will do nothing since nothing was passed and there is no Span on the scope.`
`437`	`438`	`return undefined;`
`438`	`439`	`}`
Original file line number	Diff line number	Diff line change
`@@ -190,5 +190,5 @@ export function startSpan(spanContext?: SpanContext, bindOnScope?: boolean): Spa`
`190`	`190`	* @param span `Span` instance that was created by {@link startSpan}
`191`	`191`	`*/`
`192`	`192`	`export function finishSpan(span?: Span): string \| undefined {`
`193`		`- return callOnHub<string \| undefined>('startSpan', span);`
	`193`	`+ return callOnHub<string \| undefined>('finishSpan', span);`
`194`	`194`	`}`