ref: minor optimize parse stacktrace (getsentry#2561)

Connormiha · web-flow · commit 4bc58c17c9ea · 2020-05-11T14:09:53.000+02:00
diff --git a/packages/browser/src/parsers.ts b/packages/browser/src/parsers.ts
@@ -99,6 +99,7 @@ export function prepareFramesForEvent(stack: TraceKitStackFrame[]): StackFrame[]
 
   // The frame where the crash happened, should be the last entry in the array
   return localStack
+    .slice(0, STACKTRACE_LIMIT)
     .map(
       (frame: TraceKitStackFrame): StackFrame => ({
         colno: frame.column === null ? undefined : frame.column,
@@ -108,6 +109,5 @@ export function prepareFramesForEvent(stack: TraceKitStackFrame[]): StackFrame[]
         lineno: frame.line === null ? undefined : frame.line,
       }),
     )
-    .slice(0, STACKTRACE_LIMIT)
     .reverse();
 }

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ export function prepareFramesForEvent(stack: TraceKitStackFrame[]): StackFrame[]`
`99`	`99`
`100`	`100`	`// The frame where the crash happened, should be the last entry in the array`
`101`	`101`	`return localStack`
	`102`	`+ .slice(0, STACKTRACE_LIMIT)`
`102`	`103`	`.map(`
`103`	`104`	`(frame: TraceKitStackFrame): StackFrame => ({`
`104`	`105`	`colno: frame.column === null ? undefined : frame.column,`
`@@ -108,6 +109,5 @@ export function prepareFramesForEvent(stack: TraceKitStackFrame[]): StackFrame[]`
`108`	`109`	`lineno: frame.line === null ? undefined : frame.line,`
`109`	`110`	`}),`
`110`	`111`	`)`
`111`		`- .slice(0, STACKTRACE_LIMIT)`
`112`	`112`	`.reverse();`
`113`	`113`	`}`