fix: Gracefuly handle incorrect input from onerror

kamilogorek · kamilogorek · commit 76ee66cd3824 · 2019-11-08T14:54:49.000+01:00
diff --git a/packages/browser/src/integrations/globalhandlers.ts b/packages/browser/src/integrations/globalhandlers.ts
@@ -240,13 +240,17 @@ export class GlobalHandlers implements Integration {
     event.exception.values[0].stacktrace = event.exception.values[0].stacktrace || {};
     event.exception.values[0].stacktrace.frames = event.exception.values[0].stacktrace.frames || [];
 
+    const colno = isNaN(parseInt(column, 10)) ? undefined : column;
+    const lineno = isNaN(parseInt(line, 10)) ? undefined : line;
+    const filename = isString(url) ? url : getLocationHref();
+
     if (event.exception.values[0].stacktrace.frames.length === 0) {
       event.exception.values[0].stacktrace.frames.push({
-        colno: column,
-        filename: url || getLocationHref(),
+        colno,
+        filename,
         function: '?',
         in_app: true,
-        lineno: line,
+        lineno,
       });
     }
 
